dfherr / threatclassic2 Goto Github PK

What is the feature you would like requested?

Can you add a feature that shows a warning when player is above certain threshold?
For example, when bob is above 75% threat, the screen flashes/plays a sound/shows a message until bob drops below 75%?
Maybe the threshold percentage can be adjusted too.

Is it possible to add elvui name plates support same as blizzard's indicators for aggro's color?

#37 (comment)
You close my previous post very fast and i don't think you understood my request, or i didn't understand your answer.
What i asked was threat coloring on the threat meter itself, not on the nameplates. Like tiny threat from details does it. I want everyone on the threat meter colored according to their threat, not the nameplates. Also an option to disable class colors, have everyone have the same color except my character and the tank. Or i can already do that from the options? I didnt see anything

What steps will reproduce the problem?

1. Don't be in a guild.
2. Login/reload with ThreatClassic2 activated.
3. Get message "You are not in a guild."

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

2.23

What steps will reproduce the problem?

1. Do combat things in a party or with a pet/minion

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

v2.22

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

What steps will reproduce the problem?

1. Be in a party with others, or have a pet/minion
2. Non-player performs actions that apply threat to a mob and also put player into combat

What version of ThreatClassic2 are you using?

v2.22

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

Before the Threat API patch, TC2 would display threat on a targetted mob even if the player did not have any threat on that mob. For example, I would watch the threat meter to ensure my pet had enough threat so that when I begin attacking, I won't pull aggro off it.

Threat coloring doesnt work. It says "only for blizzards nameplates", but almost everyone uses some nameplate addon. I use neat plates. Can you make it work for all nameplates? Its a very nice addition.

Also allow to set update intervals so we get faster and more responsive threat values

What steps will reproduce the problem?

1. Right click on TC2

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

2.23

Do you have an error log of what happened?

Image 1 below shows what happens when I right click on tc2
Image 2 what I should expect to see, from another in the raid group - https://imgur.com/a/Za6mDfT

We both had Assist rights

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

zhCN.zip
@dfherr

What steps will reproduce the problem?

1. ive simply tried to watch my threat for any drops, should be -540 per proc.

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

1.13.3

Do you have an error log of what happened?

no

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

Frame will not show automatically when entering combat with the option "Hide frame when out of combat" enabled

What steps will reproduce the problem?

1. Set option - "Hide frame when out of combat"
2. Target any NPC (frame not shown)
3. Get into combat with that NPC (frame still not shown)
4. Change target (frame finaly shown)

What version of ThreatClassic2 are you using?

2.12

I remember back in the day Omen used to have configurable sound cue's when your threat was approaching/overtaking the tank. This would be an amazing feature to include.

What steps will reproduce the problem?

1. Have someone use a taunt ability on a taunt-immune mob, their threat will jump up to match MT's

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

I believe 2.11
We recorded the error Feb 24 and had latest version as of that date

Do you have an error log of what happened?

No

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

We found this out on Nefarian when a warrior in our group (not MT) reactivity taunted to Nef turning. Nef did not get taunted off (immune), but the warrior's threat jumped from 23K to 70K instantly. We looked back at some of our other fights (ony) and found the same issue.

What is the feature you would like requested?

The use case for this is fairly niche, I'm not aware of any other fight where this could be used.

For Ragnaros, range can go ham without worrying about threat at all. This makes the meters less easy to follow for the melee. It would be helpful to be able to filter out all range on that fight.

Tanks may want to be able to see range threat, to use it for taunting if necessary. So I think this would have to be an option people could turn on and not just a default.

Not sure how feasable something like that would be, but I thought I'd ask.

What is the feature you would like requested?

There is a proposal, and DBM can display the version number on the same interface

What steps will reproduce the problem?

1. Play in raid
2. Have Tank
3. Generate Threat

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

2.0.7 / 6

Do you have an error log of what happened?

no, how

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally) Have a video but says do not link externally.

Tank shows up late on pull and a dps pulls aggro, eventually tank shows up on list.

I suspect it has to do with ChatThrottleLib, no prio is set so it defaults to NORMAL, most addons also don't set a prio, so all addons using chatthrottlelib are on normal. The way chatthrottlelib seems to work is it gives each channel (normal, bulk, alert) a certain bandwidth to prevent clients from disconnecting. If a channel is full it'll delay it's send and queue. I think if you used alert or bulk instead, it would send sooner since it'll split some of normal's bandwidth into alert or bulk if it has sends waiting.

Hey - the Curse link in the README doesn't work. When I search for it on the site I can only find the original CTM. I was able to install it by downloading the zip from Github, but it would be easier for my guildmates to install through the Curse Mod addon. Thanks!

First of all I wanna say thank you for making an addon like this possible, been using it since release and its awasome!!. Never stop what you doing.

So Im a mage too and been fire spec with my guildies for a bit so we can practice not pulling aggro etc before phase 5. Im trying some weak auras about ignite holder but I cant seem to adjust. The visual bars of your addon is much more easier to see and process, so I have the tank color red, mine light blue and everyone else dark grey. With the upcoming phase I have to see the threat of the other mages too and hence the title. So for example I would have the tank red color,all the mages light blue and others dark grey.

Ive saw the other requested feature to make the ignite holder different color and its an ok idea I guess. Maybe its easier this way I dont really know but a suggestion on this is maybe put a flame icon or something in front of the name so it represents the ignite holder. I think deails has a crown in front of the name if you are top DPS, so something like that.

Thank you for ur time.

What steps will reproduce the problem?

On a hunter, attack with pet without starting any attacks from your character.
On previous versions, pet threat would display in the window as soon as it damaged the mob.
On the latest version, nothing appears in the threat window until your character does damage to the mob.

• So if pet has been attacking for 5 seconds with no action from the hunter, threat window is still blank. As soon as hunter damages the mob, pet threat is shown at the correct value. Information is not being missed, it is just not being displayed.

Notes:

• Threat does not start displaying if I apply a DOT like serpent sting, only displays once damage is done
• Threat will display if mob hits hunter before pet takes aggro
• Everything is working as intended after this initial lack of information.
• This is not a addon-breaking issue, but a quality of life thing - it's nice being able to see your pet's threat lead before you start attacking.

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

v2.20
Previously was using v2.12, updated due to Blizzard releasing their threat API.

Do you have an error log of what happened?

No, since no error occurred. Should be easy to reproduce.

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

I imagine this is linked to the change to using Blizzard's threat API rather than the old method, so it's possible that there is no fix available.

What is the feature you would like requested?

Hey at first thank you for your work. Your Addon is my first choice Threat Addon.
A friend of mine has recently started using Black Amnesty (https://classic.wowhead.com/item=19166/black-amnesty). We have determined that the aggro reduction is not registered by the threat meter.
Is there a way for you to integrate the procs of this item?
Thank you and greetings from Germany!

What is the feature you would like requested?

As a tank who has to yell at DPS, I would like it if the addon made more alert noises to tell DPS to ease up. More audio cues, more flashing screen cues, basically just spam them with sensory overload until the feign death. (= I'd like those cues to be on by default, but something advanced users could turn off.

What steps will reproduce the problem?

1.When I sign in the game.

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

ThreatClassic2 v2.13

Do you have an error log of what happened?

AddOns\ThreatClassic2\core\core.lua:85: Cannot find a library instance of "LibThreatClassic2".
Count: 1

Call Stack:
[C]: ?
[C]: in function error' AddOns\BigWigs\Libs\LibStub\LibStub.lua:38: in function GetLibrary'
AddOns\ThreatClassic2\core\core.lua:85: in main chunk

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

CNwow 1.13.4

What spell(s) are affected? Please provide any relevant spell IDs/spell names.

I believe there is an issue with heroic strike producing less threat than indicated by the threat meter when using Finkle's Skinner.

If reporting your findings, please describe your methodology. If you've observed behavior that you feel is not in line with current values, please describe it.

I base this off of 2 attempts on Vael with finkle's trying to maximize heroic strike threat as a tank where the threat meter indicated a significant threat lead and yet others were gaining aggro over me.

Please provide any data you have gathered and/or evidence of any observed behavior below. If pertinent, please provide any sources that may back up your research / observations.

This is a clip of the threat meter showing the situation. Both this meter and Tiny Threat seemed to have the same issue.
https://clips.twitch.tv/MiniatureRoundPhoneKappa

Any additional information?

The 2nd time I saw the issue was obfuscated by a taunt that threw the threat meter off but prior to the taunt there was a substantial threat lead and still aggro was given to someone other than myself who was showing with the substantial lead.

What steps will reproduce the problem?

1. Target Vaelastrasz before fight starts
2. Fight starts
3. No threat is shown

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

2.08

Do you have an error log of what happened?

No

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

Are you able to make an option to change the colour of the threat bars - instead of just having teal colour?

I love to use the custom bar colors options. This is what im using at the moment:

As a mage, i will need to pay attention to whoever is the owner of the Ignite in raids, and be mindful of their threat and how fast it is approaching the tank. In later expansions, each mage had their own ignite debuff on the target, but in vanilla all mages in a raid are contributing to the same ignite stack, and whoever started that ignite (by placing the first out of five stacks) will be creditted all the threat of the ignite.

I would love a feature that allowed me to set a custom color for whichever mage is the owner of the Ignite at any particular time. While i have the ignite, my threat bar turns into the custom color. When the ignite drops off again, my bar returns to my previous setting. Another mage gets the ignite and while he does his bar changes color. That would be incredibly useful.

Thank you for this addon

What steps will reproduce the problem?

1. Open the Version Check pane
2. Click "Check All"
3. It shows only the outdated ones

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

LibThreatClassic2 / 8

Do you have an error log of what happened?

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

Currently, the value of 100% is given to the person who has the most threat, not necessarily who is holding aggro. This causes a bit of a headache when trying to figure out how close you are to pulling aggro because the percentage values shift. If I am a rogue, I want to know if I am sitting at 109% threat relative to the tank, not if the tank is sitting at 92% or so threat relative to me.

My assumption of the following option was to do exactly what I stated above:

From what I've tested, this option doesn't seem to do anything at all, there is no difference in how threat is displayed whether it is enabled or disabled, again, as far as I've tested.

Could you add profiles?

Would really love to be able to set up a global profile, so I don't have to fix the layout 10 times per realm. :)

Especially since the last update moved the addon around, it's more noticable when one has to then fix it for every character.

Thanks for the addon

I hope use WA to read the list through TC2 and present the threat ranking of mine or my designated teammates through WA.

This demand is particularly need in Hakkar/Zug, Huhuran/TAQ and other threat ranking sensitive battles.

Can you give me some help and let me to finish the project?

best regards

What steps will reproduce the problem?

1. happened during a resize of the frame (unlock, then move the frame)
   actually, it's happening 100% if trying to move the frame while locked.

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

2.11

Do you have an error log of what happened?

Message: Interface\AddOns\ThreatClassic2\core\core.lua:336: Frame ThreatClassic2BarFrame is not movable
Time: Tue Mar 3 13:02:53 2020
Count: 1
Stack: Interface\AddOns\ThreatClassic2\core\core.lua:336: Frame ThreatClassic2BarFrame is not movable
[C]: in function `StartMoving'
Interface\AddOns\ThreatClassic2\core\core.lua:336: in function <Interface\AddOns\ThreatClassic2\core\core.lua:334>

Locals: (*temporary) = ThreatClassic2BarFrame {
0 =
resizeTexture = {
}
header = {
}
resize = ThreatClassic2Resize {
}
bg = {
}
}

In this image, the tank who has aggro (thern) is listed as 100% threat with 35k. The tank below him (talanken) is listed as 38k threat yet his percentage is shown as 98%.

The percentage threat of talanken should be shown as 38/35 =108% rather than 98%.

What is the feature you would like requested?

This is reflected in koKR up to version 2.19
koKR.zip

I am experiencing a bar color issue. Everything within the ThreatClassic2 window appears with a "green tint" and I cannot find the solution. I enabled the original ClassicThreat for comparison on the LEFT, ThreatClassic2 on the Right https://i.imgur.com/pttJ0e5.jpg

What steps will reproduce the problem?

1. Installed via Twitch App
2. Enable Addon
3. Login to game and /console scriptErrors 1 after being notified of AddOns experiencing a large number of errors and may be slowing down the game.

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

ThreatClassic2-v2.07

Do you have an error log of what happened?

**Message**: [string "--[==[ Error in 'ThreatStatus']==] return ..."]":3: Cannot find a library instance of "ThreatClassic-1.0".
**Time**: Thu Jan 2 15:52:45 2020
**Count**: 3024
**Stack**: [string "--[==[ Error in 'ThreatStatus']==] return ..."]":3: Cannot find a library instance of "ThreatClassic-1.0".
**Locals**: <none>

Error happens constantly, several times per second.

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

What is the feature you would like requested?

Hello.

I suggest more options for every individual text on the bar.

In particular a checkbox to hide some of these in order to reduce visual clutter.
Dependent on the user settings for bar height and font size it can be difficult to see head to head racing bars for the top spot due to the right side being covered by amount + percentage. I often wish to be able to hide at least the percentage number, because the bar itself is already the indicator for it.

An alternative would be to give font a color transparency setting. This also reduces the contrast from white text to class color which I think makes the bars easier to look at in general. Would be neat to have in any case.

I think it would be very useful to have the ability to colour your player's bar differently from everyone else so that it's easy to see where you are on the threat meter. Maybe like a red or something for you, while everyone else is coloured by class.

What steps will reproduce the problem?

1. A hunter bring away one mob.
2. The hunter feign die.
3. Err occured

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

X-Curse-Project-ID: 355497

Version: 2.16

Do you have an error log of what happened?

Message: Interface\AddOns\ThreatClassic2\core\core.lua:234: attempt to index local 'colorUnit' (a nil value)
Time: Sat Apr 18 19:56:45 2020
Count: 1
Stack: Interface\AddOns\ThreatClassic2\core\core.lua:234: attempt to index local 'colorUnit' (a nil value)
Interface\AddOns\ThreatClassic2\core\core.lua:234: in function <Interface\AddOns\ThreatClassic2\core\core.lua:223>
Interface\AddOns\ThreatClassic2\core\core.lua:255: in function UpdateThreatBars' Interface\AddOns\ThreatClassic2\core\core.lua:338: in function <Interface\AddOns\ThreatClassic2\core\core.lua:310> Interface\AddOns\ThreatClassic2\core\core.lua:788: in function ?'
Interface\AddOns\ThreatClassic2\core\core.lua:765: in function <Interface\AddOns\ThreatClassic2\core\core.lua:764>
[C]: in function `TurnOrActionStop'
[string "TURNORACTION"]:4: in function <[string "TURNORACTION"]:1>

Locals: unit = "raidpet30"
colorUnit = nil
(*temporary) =

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

What steps will reproduce the problem?

1. As the title says
2. People are using TC2 or Details Tiny Threat

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

latest and 5-6 of our member had outdated versions of TC2 (maybe 1-2 revisions back)

Do you have an error log of what happened?

No

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

Other users seem to have the same problem according to this reddit
https://www.reddit.com/r/classicwow/comments/f5nh60/big_frame_drop_during_nefarian_phase_3/

Any idea why this happens or is it maybe caused by Details! tiny threat syncing with TC2 users through LibThreatClassic2?

Hopes you can list the advantages of ThreatClassic2 on README file, and let more players know about it. Thanks!

What is the feature you would like requested?

Add a reset button (for raid leader / assist permissions) that resets the meter to 0 for multi-phase fights like Ony.

After updating to v2.20, I found my tc2 doesn't work at all. The threat window only shows myself or 2-3 players at most, and I couldn't open settings by right-click window. I cann't even press "enter" when I type /tc2 in chat window. I tried /rl in game and reinstall but the problem still there.

What steps will reproduce the problem?

1. Mob drops threat
2. TC2 isnt reset
3. Tank still shows top threat, but heals has aggro
   ~It may not even have to do with the mob dropping threat, but that is an issue, too.
   But the main issue is with TC2 showing the tank has top threat and the mob is headed to the healer or dps. I wasn't having this issue with ClassicThreatMeter, but it had its own bugs apparently.

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

v2.11

Do you have an error log of what happened?

no, video though

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

What is the feature you would like requested?

Support colors set via the ClassColor AddOn, https://www.curseforge.com/wow/addons/classcolors

simple fix:
Change line 39 of core/core.lua to:

local RAID_CLASS_COLORS = (_G.CUSTOM_CLASS_COLORS or _G.RAID_CLASS_COLORS)

https://github.com/phanx-wow/ClassColors/wiki

What is the feature you would like requested?

I would like TC2 hidden on my druid, warrior, and paladin when not in a group. I would like it displayed on my warlock and hunter (aka, pet classes) when not in a group. This can be achieved by changing the "SavedVariables" to "SavedVariablesPerCharacter" in the .toc file.

It would be very nice if an extra row in the threat table was created, called something like "Aggro Gain". The threat value for "Aggro Gain" would be equal to threat of current targetOfTarget (unless temporary forced attack by e.g. Mocking Blow or AoE Taunt) and have a threat% of 100% for the active active tank, or modified to take aggroMod (1.3 or 1.1 for ranged resp. melee) into account for anyone not currently targetOfTarget.

In the attached screenshot, which is from the known addon KLH Threatmeter, an example of the requested behavior can be seen from the own player's perspective in a scenario where "WarriorNameX" is tanking the mob and "MyName" attacking said target:

• The blue bar "Aggro Gain" is the one already described.
• The brown bar is from the current targetOfTarget (=active tank), and is class color coded, which I understand is not possible in WoW Classic.
• The red bar is the own player one. Another request to this github project has already covered "highlight myself", so I will leave it out of this one.

An extra suggestion, that may be a step in the right direction to fulfill this request, is to modify the current threatPercent that is being returned by the function ThreatLib:UnitDetailedThreatSituation in LibThreatClassic2.lua in the following way:
Replace threatPercent = rawThreatPercent / aggroMod on line 1662
with threatPercent = rawThreatPercent

The point of this change is to have a more intuitive representation of threat% in relation to "Aggro Gain". Currently, I am experiencing overaggroing at 76% threat which I believe is a lot more confusing than overaggroing when reaching 100% threat.

I have locally modified my version of ThreatClassic2 to do the part mentioned in the section above. It looks like this, in the same scenario described earlier:

The missing features from this picture is the requested "Aggro Gain" row, described earlier, and to relate the threat percentages to current targetOfTarget, as explained earlier.

I can download from CurseForge, but would be helpful to have it on GitHub as well, thanks 👍

@dfherr The plan and time will be updated next time. Please let me know in advance. I will arrange a good time for localization. Thank you

Hello,

I would be pleased if you could implement a option which only show my Threat-Percentage on my screen.

Example: Similar to this addon for an old game Wildstar:
https://www.curseforge.com/wildstar/ws-addons/threat/screenshots

(The last screenshot shows exactly how I expect it to be - Only player threat percentage indicator which can be dragged!)

What steps will reproduce the problem?

1. Raid or dungeon with a warrior
2. Watch them be very low on the meter but high on real threat.
3. See them spike to the top of the list after some delay.

What version of ThreatClassic2 are you using? (Stating 'latest' is not useful)

2.07 Everyone in raid and in my party had this version too.

Do you have an error log of what happened?

I was very noticeable in the MC kills.
https://classic.warcraftlogs.com/reports/Lc4AwBvWbQ73DKCk/

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

Some warriors threat is displayed much lower than it actually its. After some time it will just spike and show the correct value. I believe both warriors were fury/prot hybrid specs. I'll post logs from the raid.