Code Monkey home page Code Monkey logo

bazel-ngc-wrapped-invalid-imports's Introduction

bazel-ngc-wrapped-invalid-imports

Read more about the issue here: https://hackmd.io/MlqFp-yrSx-0mw4rD7dnQQ

How to reproduce:

  • bazel build packages/material/snack-bar
  • Open ./bazel-bin/packages/material/snack-bar.js
  • See how NGC generated an import to @angular/cdk/overlay/overlay. This is incorrect as the import should always refer to public name of the entry-point.

How to reproduce the Bazel "generateCodeForLibaries" issue:

  1. yarn ngc -p test-vanilla-ngc/a/tsconfig.json
  2. yarn ngc -p test-vanilla-ngc/b/tsconfig.json.

Both of these compilations work. b properly builds with metadata of a.

Now change in test-vanilla-ngc/b/tsconfig.json the generateCodeForLibraries option and notice how the metadata of a is discarded if you rebuild b.

  1. yarn ngc -p test-vanilla-ngc/b/tsconfig.json.

bazel-ngc-wrapped-invalid-imports's People

Contributors

devversion avatar

Watchers

 avatar  avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.