It would be great to randomize the metrics path in burpcollaborator-docker/burp/conf/burp.config to increase its security slightly.

Hint: The Certificate Authority failed to verify the DNS TXT records created by --dns-cloudflare. Ensure the above domains are hosted by this DNS provider, or try increasing --dns-cloudflare-propagation-seconds (currently 10 seconds).

Some challenges have failed.
Ask for help or search for solutions at https://community.letsencrypt.org. See the logfile /var/log/letsencrypt/letsencrypt.log or re-run Certbot with -v for more details.

Hey,

First of all thanks for the awesome script.
I'm trying to set this up in Ubuntu (16.04 and 18.04) and can't figure out why the DNS-requests don't get properly sent to DNSMasq. I have delegated a whole domain to the VPS which is used for Burp Collaborator.

When I run init.sh, everything is started properly but the verification fails due to not getting TXT-record. I tried diagnosing with following commands from the docker host and these won't return the TXT-record:
dig _acme-challenge.mydomain.com @mydomain.com
dig _acme-challenge.mydomain.com @127.0.0.1

However if I run dig towards the docker container's IP, (dig _acme-challenge.mydomain.com @172.17.0.2) the TXT-record can be fetched properly.

Now if I copy the DNSMasq command that the script shows and run it directly on the Docker host, everything works fine.

Should I stop some services or do some additional configuration on the host system to make this work?

Hello,

Thanks for writing this script, Do increase the 10 seconds to user specified time. so that user can go manually & add the TXT records from dns settings.

Launching DNSMASQ...
DNSMASQ CMD: 
Waiting 10 seconds for DNS changes to propagate
Waiting for verification...
Cleaning up challenges
Failed authorization procedure. 

i have my NS at cloudflare and then point NS1 and NS2 at my vps and wildcard A name to my ip.

everytime it trys to grab the SSL i get.

DNSMASQ CMD:
/usr/sbin/dnsmasq -q --dns-rr=ssrfdns.fun,257,000569737375656C657473656E63727970742E6F7267 --txt-record=_acme-challenge.ssrfdns.fun,"NbzpeF7hngULgzUr8N1O9JZ5UvNzWFInhK4m3EQJbIc" --txt-record=_acme-challenge.ssrfdns.fun,"IOTRix3LnA4O60dMU2vkabM1tDqLX44K8UjzlPAWUjQ" --no-resolv --port=53
Waiting 10 seconds for DNS changes to propagate
NbzpeF7hngULgzUr8N1O9JZ5UvNzWFInhK4m3EQJbIc"Waiting for verification...
Cleaning up challenges
Failed authorization procedure. ssrfdns.fun (dns-01): urn:ietf:params:acme:error:unauthorized :: The client lacks sufficient authorization :: No TXT record found at _acme-challenge.ssrfdns.fun, ssrfdns.fun (dns-01): urn:ietf:params:acme:error:unauthorized :: The client lacks sufficient authorization :: No TXT record found at _acme-challenge.ssrfdns.fun

is it possible to add a new feature where if you provide something like -cf switch it updates a text record @ cloudflare via the API?

i know this txt record is being added to the dnsmasq but it does not seem to work for me.

Need to disable systemd-resolved first:

sudo systemctl disable systemd-resolved
sudo systemctl stop systemd-resolved

I was facing some Java compatibility issues when downloading recent versions of the Burp JAR file:

java.lang.UnsupportedClassVersionError: burp/StartBurp has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0

To resolve this, I had to install Java17 and made the following modifications:

in Dockerfile:

FROM debian:bullseye-slim

RUN apt-get update && \
    apt-get -yqq dist-upgrade
RUN apt-get -yqq install openjdk-17-jdk && \
    apt-get autoremove -yqq && \
    apt-get clean && \
    /bin/rm -rf /var/lib/apt/lists/*

RUN groupadd -g 999 burp && \
    useradd -r -u 999 -g burp -d /opt/burp burp

USER burp
ADD entrypoint.sh /opt/burp/entrypoint.sh
WORKDIR  /opt/burp
ENTRYPOINT ["/opt/burp/entrypoint.sh"]

in burp/conf/burp.config, add property "name" to DNS interfaces:

"dns": {
      "interfaces" : [{
          "publicAddress": ["167.172.248.65"],
          "localAddress":"0.0.0.0",
          "name":"ns1"
      }],
      "port" : 8053,
   }

It seems that the challenges sometimes change, and as such the automatic renewal script will fail.
Gotta find out why, and try to solve this...

Hi,

I got this installed on a Vultr VPS. All good with the deployment until I got this:

Do you have any workaround for this one?

Thank you!

hello. Thank you for the wonderful project... it waits for 10 seconds while creating the certificate and ends the process before i complete txt registration.what should I do?

edit:

I think the certificate can be created for cloudflare alone. I was trying to make DNS settings with google cloud before.therefore, it was waiting for 10 seconds while creating the certificate. now I started using cloudflare to make dns settings.. but again I am facing a problem. you would suggest dns configuration on the home page as follows.

example: domain name( burp.collaborator.com)

A ------------burp.collaborator.com ------------54.54.55.44

NS ----------burp.collaborator.com ----------- burp.collaborator.com

cloudflare does not allow me to configure dns as above...

orginal error:
NS records already exist with that host. (Code: 81056)

but if I set up dns as follows, cloudflare allow it

example:

A ------------ns1.burp.collaborator.com --------------54.54.55.44
NS ----------burp.collaborator.com -------------------ns1.burp.collaborator.tk

do you think this could be a problem?