devmil / muzei-bingimageoftheday Goto Github PK

Hi,

unfortunately on My OnePlus phone with Android 10 the share menu is sporadically (99% of the time) broken

Logcat tells the following messages every time it is not working:

03-01 14:46:03.418 7103 7123 D DecorView: onWindowFocusChangedFromViewRoot hasFocus: true, DecorView@486bd34[MuzeiActivity]
03-01 14:46:03.426 1445 3728 D OemSceneCallBlock: isCallBlockedWithUidIntent { act=android.intent.action.CHOOSER flg=0x10000000 cmp=android/com.android.internal.app.ChooserActivity (has extras) }, ResolveInfo{46f8dd6 android/com.android.internal.app.ChooserActivity m=0x108000}
03-01 14:46:03.428 1445 3728 I ActivityTaskManager: START u0 {act=android.intent.action.CHOOSER flg=0x10000000 cmp=android/com.android.internal.app.ChooserActivity (has extras)} from uid 10348 pid 7359
03-01 14:46:03.428 1445 3728 W ActivityTaskManager: Background activity start [callingPackage: de.devmil.muzei.bingimageofthedayartsource; callingUid: 10348; isCallingUidForeground: false; isCallingUidPersistentSystemProcess: false; realCallingUid: 10348; isRealCallingUidForeground: false; isRealCallingUidPersistentSystemProcess: false; originatingPendingIntent: null; isBgStartWhitelisted: false; intent: Intent { act=android.intent.action.CHOOSER flg=0x10000000 cmp=android/com.android.internal.app.ChooserActivity (has extras) }; callerApp: ProcessRecord{5551b50 7359:de.devmil.muzei.bingimageofthedayartsource/u0a348}]
03-01 14:46:03.431 1445 3728 E ANDR-PERF-JNI: com_qualcomm_qtiperformance_native_perf_io_prefetch_start
03-01 14:46:03.435 2077 2085 E ANDR-IOP: io prefetch is disabled

Do you have an idea why this might be happening?
Maybe it is related to
https://developer.android.com/guide/components/activities/background-starts
that was changed with Android 10
When I go to muzei settings, and open the bing image settings, it seems to count as "recently started" and the share menu shows up directly after
A solution would be great

You can add Screenshots for F-Droid, too, if you want.

https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/

https://gitlab.com/snippets/1895688

Muzei is saying "this plugin is not compatible with new api". I had to downgrade to Version 1.4 (5) and it is working.

Hi,
Could you please consider adding a "share" button in this menu?

The default "artwork" wallpaper has it, would it be possible to add it for Bing images too?
Ther eis an example of how it works in the national geographic plugin:
https://github.com/msal/muzei-nationalgeographic/blob/master/muzei-nationalgeographic/src/java/de/msal/muzei/nationalgeographic/NationalGeographicArtSource.java#L103
Thank you very much for consideration

Hi,
for some reason v1.6 does not seem to share the image any more.
I tried this
a572afa#r32364880
But it was not the root cause of the problem.
Maybe you have another idea.
Thank you!

Hi Michael,

there is the new Muzei API out which solves also issues like #4 . Do you have any plans/time to upgrade to the new API level? Would be great to hear from the author of the best Muzei plugin!

BTW: Thank you for the great work. Your plugin makes my daily use of my phone better. 👍

Hi,
We notice that you use com.android.volley as an external library. this library use API like "<org.apache.http.HttpEntity: java.io.InputStream getContent()>", "<org.apache.http.impl.cookie.DateUtils: java.lang.String formatDate(java.util.Date)>" that are already removed after SDK level 23. These API use are very likely to cause crash to your app because the minSDKVersion of your APP is 17.

There are exist reachable path from your code to these api. For example, the reachable path to the first API we mentioned above is:
<de.devmil.muzei.bingimageoftheday.BingImageOfTheDayArtSource: void onTryUpdate(int)>
--><de.devmil.muzei.bingimageoftheday.cache.BingImageCache: void ensureMissingImages()>
--><de.devmil.muzei.bingimageoftheday.cache.ImageDownloader: void download(java.util.List)>
--><de.devmil.muzei.bingimageoftheday.cache.ImageDownloader: void processNextQueueItem()>
--><de.devmil.muzei.bingimageoftheday.cache.ImageDownloadRequest: void download(android.content.Context,android.net.Uri)>
--><com.android.volley.toolbox.Volley: com.android.volley.RequestQueue newRequestQueue(android.content.Context)>
--><com.android.volley.toolbox.Volley: com.android.volley.RequestQueue newRequestQueue(android.content.Context,com.android.volley.toolbox.HttpStack)>
--><com.android.volley.RequestQueue: void start()>
--><com.android.volley.NetworkDispatcher: void run()>
--><com.android.volley.toolbox.BasicNetwork: com.android.volley.NetworkResponse performRequest(com.android.volley.Request)>
--><com.android.volley.toolbox.BasicNetwork: byte[] entityToBytes(org.apache.http.HttpEntity)>
--><org.apache.http.HttpEntity: java.io.InputStream getContent()>

We use android studio to analyze your app's apk file, and we also find methods in org.apache.http.HttpEntity don't have definition, they are all referenced methods which need android platform to support.

more bugs, please refer to this file below.
de.devmil.muzei.bingimageofthedayartsource_5.apk.txt

We cannot make 100% sure about the reachable path, so we need your help to check whether it is reachable from your code to these unsupported API. Thanks very much.

best regards,

Dongjie He

Other plugins and extensions allow to select the wallpaper resolution.

It would be great if this could be a setting for this image provider as well.

Thank you for your work! 🙏

Works great except it tends to stuck on the same image after several days of usage. Workaround to unstuck is to go to the plugin settings and then press back button, then it works again for several days.