Comments (2)
iso15765-canbus/src/lib_iso15765.c
Line 370 in 460db1f
I think this piece should not be N_ADM_EXTENDED, but N_ADM_FIXED. And when defining the enumeration of this block, the two comments FIX and EXTEN are mixed up.
iso15765-canbus/src/lib_iso15765.h
Line 108 in 460db1f
Hi @gonghanling, thank you very much for your observation. Regarding the first part with the switch-case, i need to verify better according to the ISO, however, you are correct about the comments. I'll fix it asap! Thanks again!
from iso15765-canbus.
Sorry, I didn't notice it. It can be seen in 15765-2 that Extended addressing, Byte1 needs to be filled in N_TA. So no problem.
from iso15765-canbus.
Related Issues (10)
- Multi-node communication HOT 1
- Error in operator precedence in n_pdu_unpack() HOT 3
- The function send_N_PCI_T_FC calls send_frame with wrong parameters HOT 1
- N_UNE_PDU return value in process_in_cf() HOT 2
- From which document can I find the rules for N_AI mapping to 11bit CAN ID? HOT 1
- Bugs? HOT 3
- [Question] How interact with hardware HOT 10
- Implementation in STM32HAL HOT 1
- Flow Control Management? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iso15765-canbus.