Bugs? about iso15765-canbus HOT 3 CLOSED

Thank you for taking time to check this project. Regarding the points you mentioned:

1. According to ISO-15765-2 [section 6.5.4.2 at page 19 : The SN shall start with zero (0) for all segmented messages. The FF shall be assigned the value zero (0). It does not include an explicit SequenceNumber in the N_PCI field but shall be treated as the segment number zero (0). So, the first CF should be with SequenceNumber 1 (not 0)

2. Yes, you are right!

from iso15765-canbus.

I think the SN is correct starting from 1, but when SN reaches 15, it should be 0.

According to ISO-15765-2 [section 9.6.4.3] SequenceNumber (SN) parameter definition
Last rule:

• that when the SN reaches the value of 15, it shall wraparound and be set to zero for the next CF.

https://en.wikipedia.org/wiki/ISO_15765-2
The sequence number starts at 1 and increments with each frame sent (1, 2,..., 15, 0, 1,...), with which lost or discarded frames can be detected. ...
So the first set of CF(Consecutive frames) start from "1". There afterwards when it reaches "15", will be started from "0".

from iso15765-canbus.

Fixed! Thanks!

from iso15765-canbus.