devansh016 / minimal-news Goto Github PK

You can add new screenshot of the website or anything else.

"Get in Touch" should appear in center. Also while filling the form the text is not readable properly in active input box.

For mobile devices:

1. Shifting the scroll to top button down to bottom (where the theme changes button was previously).
2. Removal of change theme floating button from feedback page.

For all devices:

1. Adding Footer to the contributor and feedback page.
2. Removal of feedback and contributor links from the header for all the pages (as they are already in footer).

Change dark mode color scheme to little less dark and more appealing.

Should we increase the number of articles and also show old articles?

Two contributors are mission find them and add them to the file

Describe the bug
UI Issue likes color doesn't match with theme, too much elements to display in single line.

Screenshots

• Color Not Matching
  
  

• Alignment Errors
  (Feedback, Contributors Page)
  

• Congested Header (Maybe there should be responsive navbar)
  

Icons had already been added in the project repo.

Is your feature request related to a problem? Please describe.
N/A

Describe the solution you'd like
I am proposing to create a Dockerfile which would enable users to run this application in a containerised environment, using Docker.

Describe alternatives you've considered
N/A

Additional context
N/A

Should we add demo articles so contributors who are working locally doesn't had to get newsapi keys?

Describe the bug
Bug in contributors page.

To Reproduce
Just check console of browser.

Screenshots

Desktop:

• Device: Lenovo Legion Y540
• OS: Windows 10
• Browser: Chrome v94

I think we need a more content footer with showing links to explore our website. Also we need links for supporting us and following!

And the benfit is if the user is scrolled down to the bottom of our website, and user need to go another router or link, you know it is easy if there are links in footer.

So I created a updated footer design in my local project! Here is how it looks like :-

Desktop :-

Mobile :-

If we need this. Let me create a PR!

Hope you got what I mean!

Make the button smaller.

Describe the bug
There is Empty Space below scroll-to-top button (UI Bug.)

Screenshots

Smartphone (please complete the following information):

• Device: All Mobiles

The current footer seems to have no top-margin and thus could possibly interfere with the content in case of some articles.

Also, the sudden use of accent color seems to pop out a bit too much

I will try to set this with proper colour and also it will also look good if u add your some social info below
something like this.

Plz check and assign @devansh016 :)

@devansh016 What about adding that package-lock.json and res/newsArticles.txt to .gitignore ?!

Yes please add them to it. I already added the res/newsArticles.txt but still facing the issue

Originally posted by @devansh016 in #78 (comment)

There is some updates on website ui, so screenshots need to be update.

Take new screenshots both in light and dark mode and update them.

Are you planning to make app installable?

PWA makes website installable on any web supporting platform(Windows, Android, ChromeOS, etc)

You have made a fine project but I might be able to add certain design elements to make website even more appealing. I am thinking of making all articles into cards.

Dark mode is too dark putting strain on eyes. New colour scheme can be defined.

What new feature can be added?

Reduce the cookie expiry time to 7 days.

I would like to contribute by solving this issue for hacktoberfest

Describe the bug
A clear and concise description of what the bug is.
Since I had designed the contributors page, I had already added myself in contributors.json. But then while adding other contributors, I suppose @devansh016 added my data again.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'deployed site'
2. Click on 'Contributors'
3. See error

Expected behavior
A clear and concise description of what you expected to happen.
My name should only be once.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows
• Browser : Chrome
• Version : 94.0.4606.71

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

should include

1. adding their details in res/contributors.json file.
2. things to avoid like removing whitespaces and sending a PR or adding only a single line.
3. and other details.

please add points if I miss something.
All instruction to be added in readme file.