dermojo / spsl Goto Github PK

Currently untested and not supported.

The currently used clang-tidy and clang-format are at v6.0, which becomes more and more outdated.
Check if there's a more recent version available (also on Travis CI).

It would be great to have an interface (pure virtual class) with std::basic_string like methods that hides the underlying string implementation + a template implementation.

It shall be possible to construct and query ArrayString[W] instances at compile time.
This means, the following methods shall be constexpr:

• Default and copy constructors (move isn't possible for constexpr objects)
• all const methods - size(), data(), find*(), ...

Example:

constexpr spsl::ArrayStringBase<char, 64> a1("I'm a stack-based string and can store 64 characters + NUL");
static_assert(a1.length() == 58, "oops...");

StoragePassword uses VirtualLock/VirtualUnlock on Windows to avoid swapping to disk. This doesn't work properly if multiple instance of the string are instantiated, because Windows doesn't keep a lock count - the first call to VirtualUnlock will enable swapping for the page again.
(need to check on munlock on Linux...)

One solution is to allocate full pages, so there are no conflicts.

Allow to build without a copy of gsl-lite (e.g. for fully dependency-free offline builds), using some CMake magic.

Currently, only Visual Studio is supported on Windows. Mingw should work as well.

Time to update to a newer standard...
That would allow more constexpr and a lot of cleanup, including removing the custom hash implementation. Also, string functions can be delegated to std::string_view.
StringCore and StringBase can be merged, there's no real benefit in the "reduced" string API set.

When using truncation in ArrayStorage, this can break multi-byte UTF-8 sequences.
First of all, there needs to be clear documentation about this problem, and second, this should be fixed (if possible).

Instead of using a Boolean template parameter, using a policy class leads to a better design.

On Linux, it's possible to exclude pages from core dumps by using madvice. Unfortunately, this requires that we work with full pages.
But since we need to use pages for #2 already, this is a viable option that should at least be offered, if it's not on by default.

We currently have no implementation for ">>" and "<<".

Use googletest as submodule instead of relying on an external installation.

Using boost::replace() fails with Clang, because there's a implicit conversion from const_iterator to iterator, which is wrong.
Need to check all usage of const_iterator...

The MurmurHash3 implementation casts the string array to a uint64_t*, which may break the alignment.
This needs investigation: What happens if the array is unaligned? How can this be fixed?

Currently, static_cast<gsl::byte>(0) isn't possible. This prevents storing bytes in any of our string classes.
It's debatable whether this makes sense, because bytes aren't strings, but reusing spsl::PasswordString as a "safe byte storage" container would be beneficial.

Travis CI integration would be great!

Integrate useful stuff from ci_helloworld