Code Monkey home page Code Monkey logo

racer-highway's People

Contributors

cray0000 avatar psirenny avatar vmakhaev avatar woodcoder avatar zag2art avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

vmakhaev cray0000 somehats ovvn mattbrun k-components droganov psirenny biggerflip adig maggnus plusbpm craigbeck ilkkah

racer-highway's Issues

Upgrade dependencies: ws and others

Could you Please upgrade deps of the package racer-highway? For today, ws package has version 7.1.*. But, as we can see here, legacy version 1.1 is used

Poor api design

Browser component is designed to be used along with browserify, it just force you to have certain environment outside the component. As a result, you can't use the transport with webpack for example.

It think, that proper design would allow the component, to be used like:
require("racer-highway/lib/browser”)(racer, clientOptions);

I can fork the project and make adjustments, but it would require changes to be made with derby-starter.

Лишние слушатели

Не понятно назначение этого слушателя:
https://github.com/derbyparty/racer-highway/blob/master/lib/server/index.js#L150

backend никогда не вызывает событие connect, более того, он не даже не слушает события share agent
зато при каждом подключении вешается новый слушатель, а старый не снимается (нет обработки disconnect)
в итоге получаем:

(node) warning: possible EventEmitter memory leak detected. 11 connect listeners added. Use emitter.setMaxListeners() to increase limit.
Trace
    at Backend.addListener (events.js:239:17)
    at doneInitialization (/home/user/someproject/public_html/node_modules/racer-highway/lib/server/index.js:150:11)
    at WebSocketServer.<anonymous> (/home/user/someproject/public_html/node_modules/racer-highway/lib/server/index.js:101:5)
    at emitOne (events.js:77:13)
    at WebSocketServer.emit (events.js:169:7)
    at /home/user/someproject/public_html/node_modules/racer-highway/lib/server/index.js:121:13
    at completeHybiUpgrade2 (/home/user/someproject/public_html/node_modules/racer-highway/node_modules/ws/lib/WebSocketServer.js:237:5)
    at completeHybiUpgrade1 (/home/user/someproject/public_html/node_modules/racer-highway/node_modules/ws/lib/WebSocketServer.js:262:13)
    at WebSocketServer.handleHybiUpgrade (/home/user/someproject/public_html/node_modules/racer-highway/node_modules/ws/lib/WebSocketServer.js:290:3)
    at WebSocketServer.handleUpgrade (/home/user/someproject/public_html/node_modules/racer-highway/node_modules/ws/lib/WebSocketServer.js:147:26)
    at next (/home/user/someproject/public_html/node_modules/racer-highway/lib/server/index.js:119:11)
    at MongoStore.<anonymous> (/home/user/someproject/public_html/node_modules/express-session/index.js:432:7)
    at MongoStore.tryCatcher (/home/user/someproject/public_html/node_modules/connect-mongo/node_modules/bluebird/js/release/util.js:11:23)
    at Promise.successAdapter [as _fulfillmentHandler0] (/home/user/someproject/public_html/node_modules/connect-mongo/node_modules/bluebird/js/release/nodeify.js:23:30)
    at Promise._settlePromise (/home/user/someproject/public_html/node_modules/connect-mongo/node_modules/bluebird/js/release/promise.js:543:21)
    at Promise._settlePromise0 (/home/user/someproject/public_html/node_modules/connect-mongo/node_modules/bluebird/js/release/promise.js:591:10)

может я чего то не знаю ?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.