@TomasVotruba said:

It looks dangerous

Ref https://www.tomasvotruba.cz/blog/2018/12/20/introducing-symfony-flex-loader/#make-kernel-small-again

After my talk I got this feedback:
https://fixmie.com/

I love that's right in the code, you can deny it and it looks like another human giving you tips :)

How hard would that be?

Idea is to create checksuite ASAP along with receiving webhook so github does not wait 30s for response. Update this checksuite after async job is done.

Use Symfony/Messenger component for it with rabbitmq transport.

https://developer.github.com/v3/checks/

User should be able to sign up with rector-ci.org and activate Rector CI for his repositories.

https://lgtm.com/

• very similar workflow - login repo, free for open-source, CI checks on Github

• X rectfied files

"Best off"

• X files changes by X Rector
• 30 files changed by Y level

Current manual deployment script in bin/deploy:

#!/usr/bin/env bash
cd ..
docker build -t rector/rector-ci .
docker push
ssh [email protected] "cd /projects/rector-ci.org && ./run.sh"

Anyways docker image rector/rector-ci is built automatically to docker hub, but it is not enough, we need to trigger on server docker-compose up

https://developer.github.com/v3/guides/best-practices-for-integrators/#secure-payloads-delivered-from-github

@TomasVotruba

TLDR:

• Be able to sign up/in on rector-ci.org with github account
• Change from commit hooks to PR hooks (when PR is opened)
• Close PR if original PR is closed
• Configure/activate sets
• If set is activated then apply this set for PR
• User should not be able to use Rector CI straight after signing up, user needs an activation, this is CLOSED BETA

Imagine there is PHP 8.0 set and everything is committed in one go. 30 rules with one commit. Very hard to rebase or modify.
In small code bases it cold be ok, but in practice it easier to work with smaller chunks.

Based on talk with @jfrnl

https://sentry.io/for/open-source/

Based on feedback after talk - if i close PR as "unwanted", and push again to that branch, PR will appear again with same changes i just denied.

Now we are using https://ngrok.com to proxy github webhooks to local server

• X rectfied files

User should be able to see list of sets and activate them one by one.

Activation of set should send PR to master branch and if accepted, then mark set as activated.

When user opens pull request to repository, his PR will be scanned by all activated sets.

@TomasVotruba i will please need list of sets possible to run which can be used and activated by user for his repository and maybe user readable name of set + features it offers, maybe examples, i do not know what things would user need to know about set 😄