denoland / setup-deno Goto Github PK

Instead of writing:

- uses: denoland/setup-deno@v1
  with:
    deno-version: v1.x

It would be nice to write:

- uses: denoland/setup-deno@v1

Then when deno v2 is released we can bump the version of this action:

- uses: denoland/setup-deno@v2

The one risk for this is if we would want to make any breaking changes to the action, but I feel we could just do that when a new major deno version release occurs.

This would not be a breaking change because not providing a deno-version currently errors.

Hello!

I tried with nektos/act locally, but setup-deno failed.
Actions Setting:

name: CI
on: [push, pull_request]


jobs:
  build:
    runs-on: ubuntu-latest
    strategy:
    name: Deno CI
    steps:
      - uses: actions/checkout@master
      - name: Setup Deno
        uses: denolib/[email protected]
        with:
          deno-version: "1.28.0"
      - run: deno run https://deno.land/std/examples/welcome.ts

I saw this log, see this image.

How do dissolution this error? Thank you.

We noticed recently in one of our projects that our GHA wasn't pulling through the correct version of denoland/setup-deno I believe this is because there isn't major and minor version tags setup that points to the same ref as the most recent version. e.g v1 / v1.1

For example: https://github.com/actions/checkout/tags

As mentioned in 3. here: https://docs.github.com/en/actions/creating-actions/releasing-and-maintaining-actions#example-developer-process

setup-node uses github's problemMatcher to automatically add error message to TSC errors; it'd be great to have the same functionality, along with matchers for fmt and lint errors.

Hi, we're seeing some error in the the Github Action runs.
It seems trying to get this URL: https://raw.githubusercontent.com/denoland/deno_website2/main/versions.json
And the error seems to be intermittent.

Any idea?

Seeing the following warning when using this action:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Have you considered becoming a verified creator on Github Marketplace? Due to corporate policy we're not allowed to use 3rd party Actions.

It would be nice if this action had a way to cache deno modules that had been downloaded in previous runs, similarly to https://github.com/actions/setup-node#caching-global-packages-data

The cache looks like it is easy enough to find https://deno.land/manual/linking_to_external_code#linking-to-third-party-code . However, I'm unsure what the key/hash for lookup and download would be to:

• Determine if a module had changed in any file.
• Lookup existing module caches.

This part is easier with a NodeJS package manager such as npm or yarn as you can just use a hash of the lockfile.

The setup-deno action does not work on the latest Deno version(s)

Run denoland/[email protected]
Error: TypeError: fetch failed

  - uses: actions/checkout@v3
  - uses: denoland/[email protected]
    with:
      deno-version: v1.x

Whilst the readme says "targets the latest stable", this isn't strictly true because that example would still target v1.x.x, even if v2.1.2 is the latest

I'd suggest clarifying that a user can still use vx.x.x syntax to target the latest, which was something I had to ask on the discord

When running in minimal containers the action fails due to a lack of unzip, eg:

https://github.com/teaxyz/cli/actions/runs/4105361554/jobs/7082110062#step:4:8

You may feel this is “working as designed” in which case I’ll submit a PR for the README. Or perhaps you think this action should work even if unzip is not available—in which case perhaps there is a package npm or otherwise that will uncompress for us?

Seeing the following warning message when using this action:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: denoland/setup-deno

Can see node12 is set here: https://github.com/denoland/setup-deno/blob/main/action.yml#L17

https://github.com/kt3k/deno-bin/actions/runs/5340170567/jobs/9679669961#step:3:3

A few issues here:

1. I am getting Error: Failed to fetch stable version info from raw.githubusercontent.com. Please try again later.. I am using denoland/setup-deno@v1.
2. Digging through the v1 branch, the error message is incorrect because the file being fetched is from https://deno.com/versions.json
3. At the moment, curl -I "https://deno.com/versions.json" takes a long time to complete so I suspect the fetch is timing out.

⟩ time curl --no-progress-meter -I "https://deno.com/versions.json"
HTTP/2 200
content-type: application/json
cross-origin-embedder-policy: same-origin
cross-origin-opener-policy: same-origin
cross-origin-resource-policy: same-origin
referrer-policy: strict-origin-when-cross-origin
strict-transport-security: max-age=63072000; includeSubDomains; preload
x-content-type-options: nosniff
x-frame-options: DENY
date: Tue, 22 Aug 2023 08:06:08 GMT
via: http/2 edgeproxy-h
server: deno/gcp-asia-northeast1


________________________________________________________
Executed in   10.22 secs      fish           external
   usr time   14.08 millis    8.86 millis    5.22 millis
   sys time   12.91 millis    4.65 millis    8.26 millis

Previously .deno/bin was added to the path when using denolib/setup-deno.
https://github.com/denolib/setup-deno/blob/3c5f954c869f1b0d106e129797480905587250f5/src/installer.ts#L80
Now this is no longer the case.

This is a shame because if one installs tools with deno install then they are not found.

I personally use a .dvmrc file to keep track of the deno version used for that specific repo/project, so it would be helpful to have the possibility to have the action read that instead of having to update in two places.

This is supported by actions/setup-node, like:

  - name: Setup node
    uses: actions/setup-node@v2
    with:
      node-version-file: '.nvmrc'

So it could be supported with something like:

  - name: Setup Deno
    uses: denoland/setup-deno@v1
    with:
      deno-version-file: '.dvmrc'

Hi,

it might be convenient to document in the Readme how to test multiple versions using matrix builds, e.g.:

# This workflow will test on Deno lastest stable major and canary
# see https://github.com/marketplace/actions/setup-deno for details
name: Deno CI
on: [push, pull_request]
jobs:
  build:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        deno-version: [vx.x.x, canary]
    steps:
    - uses: actions/checkout@v2
    - name: Use Deno ${{ matrix.deno-version }}
      uses: denoland/setup-deno@v1
    - run: deno test

I have this working at https://github.com/seriousme/durable-data/blob/master/.github/workflows/deno-ci.yml

Kind regards,
Hans

ref denoland/deno_std#1003

i was using denoland/setup-deno@main and started getting a 404 for the URL not working.
https://github.com/denoland/deno/releases/download/v1.11.1/deno-x86_64-unknown-linux-gnu.zip

https://github.com/influxdata/influxdb2-sample-data/runs/2834094631?check_suite_focus=true#step:2:5

i fixed it by using denoland/setup-deno@v1 which uses https://dl.deno.land/release/v1.11.1/deno-x86_64-unknown-linux-gnu.zip to download deno.

Currently, one of my build crashes because setup-deno is on old checkout action

there was a commit recently but it's not published on marketplace