deno-libs / tinyhttp Goto Github PK

Reproduction:

import { App } from 'https://denopkg.com/deno-libs/tinyhttp@master/mod.ts'
import { makeFetch } from 'https://deno.land/x/[email protected]/mod.ts'

const app = new App()

app.route('/').get((req, res) => void res.end(req.url))

const res = await makeFetch(app.handler)('/')
res.expect(200)

This is to keep the framework in line with Deno's module expectations. That also makes the module more compatible with tools like trex which expects that on installation!

• Coverage (Coveralls)
• CI (Actions)
• Code quality (Codefactor)

I've been trying to move from legacy std/http but didn't manage to do it, so anyone else is welcome

• basic
• eta
• mongodb
• postgresql
• jwt
• async
• no-match-handler
• graphql

Description

ATM res.sendFile doesn't work properly and causes tests to hang because it opens file but doesn't close them. In Opine, there's a private property for storing resources and end function closes them. tinyhttp should have something similar.

Task

Add #resources to the App class, update res.sendFile and res.end to work nicely together

This is the issue to track progress of Express API implementation

App

Properties

• app.locals
• app.mountpath

Methods

• app.all()
• app.engine()
• app.listen()
• app.path()

• app.render()
• app.route()
• app.set()
• app.use()

Request

Properties

• req.app
• req.body
• req.cookies
• req.fresh
• req.hostname
• req.ip
• req.ips
• req.method
• req.params
• req.path
• req.protocol
• req.query
• req.route
• req.secure
• req.signedCookies
• req.stale
• req.subdomains
• req.xhr
• req.originalUrl
• req.is

Methods

• req.accepts()
• req.acceptsCharsets()
• req.acceptsEncodings()
• req.acceptsLanguages()
• req.get()
• req.is()
• req.range()

Response

Properties

• res.app
• res.locals

Methods

• res.append()
• res.attachment()
• res.cookie()
• res.clearCookie()
• res.download()
• res.end()
• res.format()
• res.get()
• res.json()
• res.jsonp()
• res.links()
• res.location()
• res.redirect()
• res.render()
• res.send()
• res.sendFile()
• res.sendStatus()
• res.set()
• res.status()
• res.type()
• res.vary()

• App (port tests from original repo)
• Request (port tests from original repo)
• Response (port tests from original repo)

Reproduction:

import { makeFetch } from 'https://deno.land/x/[email protected]/mod.ts'

const app = new App()

app.use('/abc', (_req, res) => void res.end('Hello world'))
;(await makeFetch(app.handler)('/abc/def')).expectStatus(200).expectBody(
  'Hello world',
)
;(await makeFetch(app.handler)('/abcdef')).expect(404)

Reproduction:

import { App } from 'https://denopkg.com/deno-libs/tinyhttp@master/mod.ts'
import { makeFetch } from 'https://deno.land/x/[email protected]/mod.ts'

const app = new App({
  onError: (err, req) =>
  new Response(`Ouch, ${err} hurt me on ${req?.url} page.`, {
    status: 500,
  })
})

const subApp = new App({
  onError: (err, req) =>
  new Response(`Handling ${err} from child on ${req?.url} page.`, {
    status: 500,
  })
})

subApp.get('/route', async (req, res, next) => await next('you'))

app.use('/subapp', subApp)

const server = app.handler
const fetch = makeFetch(server)

const res = await fetch('/subapp/route')
res.expectStatus(500).expectBody('Handling you from child on /subapp/route page.')

Hey @talentlessguy. I tried to install tinyhttp-deno, but got the following error:

➜  payment-receiver deno run main.ts
Download https://deno.land/x/[email protected]/extensions/format.ts
Download https://deno.land/x/[email protected]/extensions/download.ts
error: Import 'https://deno.land/x/[email protected]/extensions/format.ts' failed: 404 Not Found
    at https://deno.land/x/[email protected]/response.ts:6:0

Would you take a look?

Deno coverage randomly drops on different levels and now it just dropped to 0% for no apparent reason

this should be fixed ASAP

...if I only knew how...