denkristoffer / filmbuff Goto Github PK

Search result does not seem to be useful even if I give full details of the movie title.

> ap imdb.search_for_title('back to the future 1985', limit: 2)
[
    [0] {
                :type => "title_approx",
             :imdb_id => "tt5124786",
               :title => "Back to the 2015 Future",
        :release_year => "2015"
    },
    [1] {
                :type => "title_approx",
             :imdb_id => "tt1841512",
               :title => "Back to the Future: The Game - Episode 5, Outatime",
        :release_year => "2011"
    }

$ gem install filmbuff
ERROR: While executing gem ... (Gem::DependencyError)
Unable to resolve dependencies: filmbuff requires httparty (> 0.7.4); httparty-icebox requires httparty (> 0.8.1)

current httparty version in gem repo is 0.8.3

the httparty-icebox seems to install fine by itself, though, taking in 0.8.3 , so not sure why that secondary message came up.

icy`

DEPRECATION WARNING: This api is deprecated, refer to the documentation for the new one.

i get the following error when i try to use the gem in a rails app.

require 'filmbuff'
imdb = FilmBuff.new

NoMethodError: undefined method `new' for FilmBuff:Module

seems like i have to use the old syntax:

imdb = FilmBuff::IMDb.new

I'm considering making the array of searched title types easier to use by removing the need for the "title_" prefix, so that %w(title_popular title_exact) would become just %w(popular exact), for instance. The reason I'm still considering the change is that the types would then no longer be identical to the types returned from IMDb. Does that matter to anyone?

Thoughts?

FIlm Buff needs to implement handling of title searches that redirect to a specific title. A FilmBuff::Title object should be returned.

I was going to add this back in the day but I never got around to it. I've since forgotten which search query I found that required this functionality, so I don't expect to work on this until I find another query where the redirect happens – or until someone else finds one and tells me about it.

Hi

Was testing out filmbuff to replace the imdb project.

>> fb  = FilmBuff.new
>> fb.search_for_title('Star Wars: Episode VII - The Force Awakens', limit: 2)
JSON::ParserError: A JSON text must at least contain two octets!
        from ../shared/bundle/ruby/2.2.0/gems/json-1.8.3/lib/json/common.rb:155:in `initialize'
        from ../shared/bundle/ruby/2.2.0/gems/json-1.8.3/lib/json/common.rb:155:in `new'
        from ../shared/bundle/ruby/2.2.0/gems/json-1.8.3/lib/json/common.rb:155:in `parse'
        from ../shared/bundle/ruby/2.2.0/gems/filmbuff-1.0.0/lib/filmbuff.rb:88:in `search_for_title'
        from (irb):9
        from ../shared/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/console.rb:110:in `start'
        from ../shared/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/console.rb:9:in `start'
        from ../shared/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:68:in `console'
        from ../shared/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
        from ../shared/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/commands.rb:17:in `<top (required)>'

Debugging line #88 the response is empty which trips up the JSON.parse.

Searching for just "Star Wars" works fine and returns a result.

Would be great to have access to the episodes of a TV-series

As per lostisland/faraday#454 Faraday development is winding down, so Film Buff 1.0 should move to something else.

I am thinking about going to either Hurley, which is Faraday's successor, or http.rb, which might be more stable, avoiding future changes. Any thoughts?