denishamann / arenastats Goto Github PK

Not sure how to reproduce. However, addon some times adds matches with Duration close or equal to 0s right after an actual match.
Before saving a new row of data, it could be smart to check the Duration. Because of the wait time, no arena match can be below 1 minute.
If the match duration is below 1 minute, the addon could make some comparisons to the game before it, and delete if it's a duplicate entry.


Pasted above are two entries that easily could have been filtered out and thrown away. (Note that the Duration is not always 0s)

Expected behaviour:
Each item on the match list is a unique match.

Suggested fix:
Set a unique "entry ID" at the start of each match, and only add entries to the list if the ID is unique.

Hi,

I receive the following error when the arena game is finish:

Message: Interface\AddOns\ArenaStats\ArenaStats.lua:131: attempt to index a nil value
Time: Thu Jan 5 20:52:45 2023
Count: 1
Stack: Interface\AddOns\ArenaStats\ArenaStats.lua:131: attempt to index a nil value
[string "@interface\AddOns\ArenaStats\ArenaStats.lua"]:131: in function SetLastArenaRankingData' [string "@Interface\AddOns\ArenaStats\ArenaStats.lua"]:177: in function ?'
[string "@interface\AddOns\ArenaStats\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:119: in function <...ats\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@interface\AddOns\ArenaStats\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...ats\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@interface\AddOns\ArenaStats\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function Fire' [string "@Interface\AddOns\ArenaStats\Libs\AceEvent-3.0\AceEvent-3.0.lua"]:120: in function <...AddOns\ArenaStats\Libs\AceEvent-3.0\AceEvent-3.0.lua:119> [string "=[C]"]: in function SetBattlefieldScoreFaction'
[string "@Interface_Wrath\FrameXML\WorldStateFrame.lua"]:559: in function WorldStateScoreFrameTab_OnClick' [string "@Interface_Wrath\FrameXML\WorldStateFrame.lua"]:61: in function <Interface_Wrath\FrameXML\WorldStateFrame.lua:58> [string "=[C]"]: in function Show'
[string "@Interface_Wrath\FrameXML\UIParent.lua"]:2214: in function SetUIPanel' [string "@Interface_Wrath\FrameXML\UIParent.lua"]:2020: in function ShowUIPanel'
[string "@Interface_Wrath\FrameXML\UIParent.lua"]:1927: in function <Interface_Wrath\FrameXML\UIParent.lua:1923>
[string "=[C]"]: in function SetAttribute' [string "@Interface_Wrath\FrameXML\UIParent.lua"]:2733: in function ShowUIPanel'
[string "@Interface_Wrath\FrameXML\WorldStateFrame.lua"]:130: in function `WorldStateScoreFrame_Update'
[string "@Interface_Wrath\FrameXML\WorldStateFrame.lua"]:48: in function <Interface_Wrath\FrameXML\WorldStateFrame.lua:44>

Should either flush matches before doing the export, or at least warn the user to reload his game before exporting.

Instead of storing opponent classes per Arena1/2/3, use some type of sorting so that classes appear in a consistent order. This would make the addon much more readable and make the data easier to work with.

e.g.

Rogue mage priest could appear

RMP
PMR
MPR
MRP
RPM

when leaving a game, it will combine matches instead of correctly separating out.

this makes the data useless

the lastest version (0.1.0) can not open the window （the verion 0.0.1 works fine）
whatever use the button or console (/arenastats) or disable all the other adds.

I would like to see recorded opposing team rating and rating change, this is displayed in blizzard scoreboard at the end of arena.

In addition to the way ArenaStatsTBC currently records skirmishes, the addon should equally filter out wargames. Splitting the data into "rated" and "unrated" should correctly filter out both skirmishes and wargames.

To reproduce:

1. Make two groups with two level 70 players in each group, where the leader of the other group is on your Battle.net friends list.
2. Type "/wg Battle#1234 nagrand" into the chat, where "Battle#1234" is replaced with your friend's Battle.net ID.
3. Win or lose, but stay in the match until a winner is announced.
4. Check "/arenastats toggle" to see how (or if) the game was recorded.

Expected behaviour:
After step 4, the wargame should not be listed together with the ranked matches.

Hello, good evening.

Sadly since wotlk, my arenastats doesnt work anymore :( it worked well without any problems during the whole tbc classic addon.

I Currently tried every single way to fix it, from installing it multiple times and deleting it multiple times, downloading from different sources, nearby everything that did come in my mind i tried and nothing worked, sadly. I noticed that it recorded random 3 games but since then it did never recorded any 2s/3s/5s ranked or unranked. If i can give any information about my speccs let me pls know.

thanks and regards

Installing ArenaStatsTBC for TBC using WoWUp by inputting the URL of this repository yields the following error:

Given the popularity of WoWUp and the lack of Curseforge as an option, it is highly recommended you make this repository compatible with WoWUp in order to allow ease-of-use when installing. Otherwise the only option given to users is manually updating, which is not ideal.