denimmazuki / urlshortener Goto Github PK
View Code? Open in Web Editor NEWA URL Shortener Service built with Java, Spring Boot, and Redis
urlshortener's People
Contributors
Stargazers
Watchers
Forkers
vikassivaravindran liu1084 jrmolin mysoko wongswoon arniesaha naxa777 ninjayoto misoboy anandchakru-archives oseferi spring-boot-framework lakshman82 maximfischuk vpkreddi arndff marcelocaser jeswinlouis brunopmoraes luongnv18 gaecom joskid gandhikim1002 peterturkson102 kamleshkc2002 forharsh sohm22 java-salehian t1seungyurlshortener's Issues
why use redis?
why use redis?
Configure CI/CD
Integrate Travis CI with your GitHub repo. Add a build status badge in README.
Remove redundant files from Git
Problem: out directory is checked in and contains files generated by IDE (i.e. build output).
Solution: Delete out directory; ignore out directory.
Produced short URL is not a well-formed URL
for some reason, URLConverterService produces a malformed URL, like http:localhost...
expected: http://localhost... (notice the double slash).
log
2019-03-07 05:15:45.914 INFO 20712 --- [nio-8080-exec-3] u.app.controller.URLController : Received url to shorten: twitter.com
2019-03-07 05:15:45.915 INFO 20712 --- [nio-8080-exec-3] u.app.service.URLConverterService : Shortening twitter.com
2019-03-07 05:15:45.916 INFO 20712 --- [nio-8080-exec-3] u.app.repository.URLRepository : Incrementing ID: 4
2019-03-07 05:15:45.917 INFO 20712 --- [nio-8080-exec-3] u.app.repository.URLRepository : Saving: twitter.com at url:4
2019-03-07 05:15:48.605 INFO 20712 --- [nio-8080-exec-3] u.app.controller.URLController : Shortened url to: http:localhost:8080/e
screenshot
The issue is reproducible with twitter.com as well as with https://twitter.com.
Add a link to article in README
I've discovered your repository after reading the article https://hackernoon.com/url-shortening-service-in-java-spring-boot-and-redis-d2a0f8848a1d
It would be nice to have a cross-link to HackerNoon for those who discover this repository by other means. What do you think?
A valid long URL is not shortened
Test URL: "http://maps.google.com?f=q&hl=en&q=340+hagey+blvd+waterloo+ontario"
Actual Result: 500 Internal Server Error
Expected Result: 200 OK
Reason: URLValidator does not allow query parameters >_<
Log
2019-03-07 05:25:21.091 INFO 20712 --- [nio-8080-exec-7] u.app.controller.URLController : Received url to shorten: http://maps.google.com?f=q&hl=en&q=340+hagey+blvd+waterloo+ontario
2019-03-07 05:25:21.096 ERROR 20712 --- [nio-8080-exec-7] o.a.c.c.C.[.[.[/].[dispatcherServlet] : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is java.lang.Exception: Please enter a valid URL] with root cause
java.lang.Exception: Please enter a valid URL
at urlshortener.app.controller.URLController.shortenUrl(URLController.java:38) ~[classes/:na]
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:na]
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:na]
at java.base/java.lang.reflect.Method.invoke(Method.java:566) ~[na:na]
at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:189) ~[spring-web-5.1.5.RELEASE.jar:5.1.5.RELEASE]
at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:138) ~[spring-web-5.1.5.RELEASE.jar:5.1.5.RELEASE]
at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:102) ~[spring-webmvc-5.1.5.RELEASE.jar:5.1.5.RELEASE]
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:895) ~[spring-webmvc-5.1.5.RELEASE.jar:5.1.5.RELEASE]
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:800) ~[spring-webmvc-5.1.5.RELEASE.jar:5.1.5.RELEASE]
at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:87) ~[spring-webmvc-5.1.5.RELEASE.jar:5.1.5.RELEASE]
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1038) ~[spring-webmvc-5.1.5.RELEASE.jar:5.1.5.RELEASE]
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:942) ~[spring-webmvc-5.1.5.RELEASE.jar:5.1.5.RELEASE]
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1005) ~[spring-webmvc-5.1.5.RELEASE.jar:5.1.5.RELEASE]
at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:908) ~[spring-webmvc-5.1.5.RELEASE.jar:5.1.5.RELEASE]
Screenshot
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.