deltabeard / snes9x2010 Goto Github PK

This would mean that msys would no longer be required for make.

Lots of redundant and unreadable logic.

The original code format for Snes9x is clear. Some new additions over the years do not adhere to this format. A .clang-format file should be written with the correct settings to automatically fix these issues.

For a possible (but unlikely) increase in speed.

Settings required for good emulation should be constant. There should be no case where these settings would need to be modified by the frontend.

Settings.FrameTimePAL = 20000;
Settings.FrameTimeNTSC = 16667;
Settings.SoundPlaybackRate = 32000;
Settings.SoundInputRate = 32000;
Settings.HDMATimingHack = 100;
Settings.BlockInvalidVRAMAccessMaster = true; 

I fixed them all, but logs are not printing properly.

[Libretro INFO] %s: %s

Additionally, write function that allows the modification of the Snes9x settings, instead of relying on changing values in a struct.

Instead of writing to file, return an allocated buffer which the frontend can handle.

The player may encounter glitches due to speedhacks. By logging the use of it, the player may disable speedhacks in settings and replay the game instead of recording an emulation bug.

In src/cpuexec.c +363

The native sampling rate of the SNES should be used. The frontend must handle all the required resampling. Audio should not be resampled twice, so the one within Snes9x must be removed (if it's still there).

The core (Snes9x library) shouldn't access the filesystem directly. Instead, it should receive the allocated buffer of the loaded content in RAM from the frontend. Everything else like snapshot functionality should be done in a buffer.

This may already be the case with memstream, but at least remove references to filenames, etc.

The correct pitch value must be returned by the PPU. It shouldn't be defined by the frontend.
Whenever a resolution change is detected, the PPU must notify the frontend before a redraw occurs via SET_GEOMETRY, and change the pitch value as required. This pitch value needn't be stored in the Settings structure.