deathau / cooklang-js Goto Github PK

While working on the localization of your Obsidian plugin, I encountered an issue.

Timer units are parsed by checking only the first letter (thanks @seeyouspacecorgi for pointing that out). This works if the recipe is written in English, but it creates problems with other languages, ranging from unrecognized values (4%ore is not identified as 4 hours) to wrong values (4%Stunden would become 4 seconds instead of 4 hours).

I will gladly submit a patch, but we need to define what the acceptable values would be. The current implementation is lenient towards accepting weird values (4%minnites would work fine), while localization would necessarily require a finite list of values (for instance, s, second and seconds; it would become s, secondo and secondi in Italian, s, Sekunde and Sekunden in German, etc.), which could potentially break some of the existing recipes. While I would argue that such a recipe needs fixing anyway, the final word on this should not be mine.

When no ingredient amount is specified, the parser assigns it a default value of 1, which can sometimes lead to nonsensical ingredient lists.

For example:

Then add @salt and @ground black pepper{} to taste.

becomes

• 1 salt
• 1 ground black pepper

when what I meant was to add some salt and some pepper

Would it be possible for the amount be some sort of undefined instead ?