The order of Props and State in inconsistent between the readme and the code about use-url-state HOT 4 CLOSED

Hi Harry!

Good spot on the readme, fancy submitting a PR?

Im not so sure about swapping the type parameters though, it seems to vary by library whether they are 'T' first or 'Props' first:

• https://github.com/jaredpalmer/formik/blob/master/src/withFormik.tsx#L80
• https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-redux/index.d.ts
• https://github.com/styled-components/styled-components/blob/fcf6f3804c57a14dd7984dfab7bc06ee2edca044/typings/styled-components.d.ts#L94

I plan on releasing 3.0 soon (to coincide with the release of hooks) so now would be the time to swap them.

from use-url-state.

I just meant that when you use react components you normally do something along the lines of class MyComponent extends React.Component<Props, State>, and so I'd expect to always have props and state in that order. I'm happy to submit a pull request for just the readme though, if you'd prefer

from use-url-state.

If you submit a PR for just the readme that would be great. Still undecided about the type parameter order.

from use-url-state.

I'm inclined to agree with Dean, there isn't really any convention about ordering of generic types for higher order components - there are good arguments for either way here.

I don't think that's a strong enough reason to make a breaking change here, so I think it'd be worth sticking with how it already works.

from use-url-state.