ddev / ddev-addon-template Goto Github PK

Remaining work:

• References in the README to projects that haven't been moved yet
• brew install drud/ddev/ddev references have to be changed, especially if those don't work after migration.

"
GitHub will suspend the scheduled trigger for GitHub action workflows if there is no commit in the repository for the past 60 days. The cron based triggers won't run unless a new commit is made. It shows the message "This scheduled workflow is disabled because there hasn't been activity in this repository for at least 60 days" under the cronjob triggered action.
"

DDEV addons will become stable at some point and no longer require frequent commits. However, we still need to runs tests against newer versions of DDEV.

Enter https://github.com/gautamkrishnar/keepalive-workflow

We need to:

• add keepalive workflow to workflow template
• document why it is there

The test workflows for this template are repeated in every copied repo, so everything has to be updated when anything breaks, like

• #27

But I would think we could create a GitHub action that would package up most of the setup that we do, and then the action could be updated instead of having every add-on repo needing to be updated.

I would think that at least this could be done by an action:

and probably this too:

Any interest @tyler36 or anybody else? Could be fun!

The README should mention that the LICENSE file's copyright info should be updated after using the template.

In addition, does this project have a copyright? If so, how would you show that in the license without other projects accidentally copying it?

Tests should run on pull request.

The README says to push to github and then:

Test manually with ddev get <owner/repo>.

But AFAICT, you can muck about with this locally and do: ddev get PATH-TO-LOCAL-CLONE.

(This is based on doing that and then ddev restart, I have no idea if things might go wrong beyond that.)

The README says:

Globally replace "addon-template" with the name of your add-on.

So the name used in install.yaml as a sample should be that too so it gets picked up by that replacing.

Although we brew install bats-aassert bats-file we don't actually load them properly, so they're not available for use. brew info bats-assert for example tells us:

==> Caveats

To load the bats-assert lib in your bats test:

    load '/home/linuxbrew/.linuxbrew/lib/bats-support/load.bash'
    load '/home/linuxbrew/.linuxbrew/lib/bats-assert/load.bash'

==> Caveats

To load the bats-file lib in your bats test:

    load '/home/linuxbrew/.linuxbrew/lib/bats-support/load.bash'
    load '/home/linuxbrew/.linuxbrew/lib/bats-file/load.bash'

It's not clear from the README how you specify in the install.yaml and where you place a file that you want to go into a subfolder, e.g. commands/web/mycommand.

removal_actions specifically are missing from the demonstration install.yaml here.

Maybe there are other things missing, https://ddev.readthedocs.io/en/latest/users/extend/additional-services/#sections-and-features-of-ddev-get-add-on-installyaml