ddcorkum / ctmod Goto Github PK

Issue: CT_BottomBar loads more slowly than other addons during the initial boot process (fresh login, not /reload); but its unclear if this is actually affecting user experiences or just CT_BottomBar getting blamed for ordinary delays in fetching server data.

Suggested resolutions:

• Compare user experiences with different addon enabled configurations
• Experiment with deferring work until later in the boot process (such as PLAYER_LOGIN)
• Experiment with deferring event hooks until later in the boot process (such as PLAYER_LOGIN)

Problem: CT_BarMod checks for several settings on every bar before and after combat lockdown, costing several milliseconds.

Suggested solution: Modify updateGroups() or group:update() to change only settings that have been modified, including any changes that needed to be deferred because of combat lockdown.

Problem:

• CT_BuffMod can insecurely sort non-expiring buffs, but cannot filter them.

Possible Solution:

• Expand the non-expiring buffs dropdown to include "Hide" and "Only Show" as options.

Discussion:

• 8.3.0.9 recently made it easier for users to find the "Use non-secure buff buttons" checkbox; but this only partly addressed the problem.
• The term "cancellable buffs" is also increasingly misleading on Retail, as many non-expiring buffs are impossible to cancel. This might be an opportunity to rename that option just "buffs"

References:

• https://us.forums.blizzard.com/en/wow/t/ui-feature-request-for-secureauraheadertemplate/381685
• https://www.curseforge.com/wow/addons/ctmod?comment=909 (es50678)
• https://www.curseforge.com/wow/addons/ctmod?comment=934 (Nickyjean01)

Addons are now enabled in the Beta but CTMod is not working. I would really appreciate it if you could fix it anytime soon.

I've just recently started testing / using the CT_Viewport module and it's working wonderfully. I tried to find a way to disable the 'CT_Viewport is current active! /ctvp to tweak settings /ctvp 0 0 0 0 to restore default' message that happens on login / UI reload, but had no luck. Is it possible to add the option to disable these messages?

Perhaps I'm missing a setting, but I thought there used to be a setting to hide the window name, or to hide it when it's locked.

Now there's a big glaring "WINDOW 1" that I can't hide unless I move it off the edge of the screen.

Thoughts?

Following the steps in the 'Use Import String' tooltip I get this error

1x CT_Library\CT_Library-9.1.0.3.lua:3822: attempt to index global 'actions' (a nil value)
[string "@CT_Library\CT_Library-9.1.0.3.lua"]:3822: in function <CT_Library\CT_Library.lua:3784>
[string "@CT_Library\CT_Library-9.1.0.3.lua"]:3882: in function <CT_Library\CT_Library.lua:3848>

Locals:
text = "=M?/E9cRV+2:e:85eIe[@s)&J83-HV?RMI8Q77R=\W]I\]5SZ.O(3@*PJH=aMMTTYXb\\,I9=DGEbc[XDD5aU-S\>ddE+cUJe'HU=:WV\'AC3QH3)8dM8UZT\-Y@d1(W(?T<L8aJ1QGH?L<aK]McT-W9e(aRAeV@WdLcG@?KO8;KG:@:<^89)77_CS/,M+aE=]WPC_C]5P[RAGI;CXIbT1QbQJUYI&GT<L@,BC2.8^>;6W10?+?YGF.G,L>*+G77,U42:,(U;;PZ]''++4B:*:>K7:?1_1=1\eU_JE&S08CTZE-Tc18(HKbR*[eZeSH+)\Ad[LH)Gae]=WY8Z-5^=]@,(],[]81cTGK10AAa6DM+Y.&E&'&/DM,+0/0^;XD+/>BJ/WPG,;*JL,*1U:*O;*V63R&1M(7FeN48.*(X_P2<*U)RG\9CdSa[@6;?(4<E`5ad65DR_a5e9RZaaYZ4ea?TdG5@A6@6>Q'@ql[B_E\Z5C@&J:)K*41B)8-L]c0O(KDNNGe+2&b)OQ9==b/Y\5DZPJ.>8TA["
(*temporary) = nil
(*temporary) = {
0 =
warning = {
}
Title = {
}
label = {
}
acceptButton = {
}
cancelButton = {
}
editBox = {
}
}
(*temporary) =
(*temporary) = defined @CT_Library\CT_Library.lua:3702
(*temporary) = defined @CT_Library\CT_Library.lua:3702
(*temporary) = nil
(*temporary) = {
0 =
Right = {
}
Left = {
}
Middle = {
}
}
(*temporary) = "attempt to index global 'actions' (a nil value)"
copyFromClipboard = defined @CT_Library\CT_Library.lua:3763
lib =

Hi since the latest patch (9.1.0) I can't activate the following macro I have in bar 2 by hotkey:

#showtooltip Himmlische Azurwolkenschlange
/wirken [button:1] Himmlische Azurwolkenschlange
/wirken [button:2] Teufelsfeuerfalke
/wirken [button:3] Mechanischer Holzextraktor

When I click on it with the mouse it works as usual, but the hotkey by keyboard does not work since the new patch.

If I put the same macro on bar 3 it works by hotkey/keyboard.

Would be really great if that works again. Sorry for my English I am from Austria :)

Thanks in advance and best regards Nina

If I have Leatrix Maps activated I cant get the "Where am I?" button to show. The CT_MapMod button is only showing at a specific size of the map, when the LeatrixMaps option "Unlock Map Frame" is activated.

Issue:

• Group/role/class labels no longer appear in the latest CTRA version, except briefly when a new group is added for the first time

Reference:

• Requested by Francomarx at CurseForge comment 1072

Entry in taint.log believe related to CT_UnitFrames. Appears when playing Windwalker, possibly related to using Storm, Earth and Fire.

11/5 01:07:16.636 Interface\FrameXML\TextStatusBar.lua:54 TextStatusBar_UpdateTextStringWithValues()
11/5 01:07:16.636 An action was blocked in combat because of taint from CT_UnitFrames - PetFrame:SetPoint()
11/5 01:07:16.636 Interface\FrameXML\PetFrame.lua:56 PetFrame_UpdateAnchoring()
11/5 01:07:16.636 Interface\FrameXML\PetFrame.lua:85 PetFrame_Update()
11/5 01:07:16.636 PetFrame:OnShow()
11/5 01:07:16.636 PetFrame:Show()
11/5 01:07:16.636 Interface\FrameXML\PetFrame.lua:67 PetFrame_Update()
11/5 01:07:16.636 Interface\FrameXML\PetFrame.lua:103 OnEvent()
11/5 01:07:16.636 Interface\FrameXML\UnitFrame.lua:921

Issue:

• Custom CT_BarMod action buttons lack a 'recharge' animation timer

Suggested Resolution:

• Integrate GetSpellCharges() as a background cooldown animation

References:

• Requested by MrKnubbles at CurseForge comment no. 1076

When I go to the guild bank the bags won't open or close when done ? Have to manually do it.

Ref: https://www.curseforge.com/wow/addons/ctmod?comment=1215

Issue: CT_BarMod custom action bars do not update to show a new icon when abilities change, such as the 9.0 Shadowlands Covenant abilities.

Solution: Call updateTexture() in response to SPELL_UPDATE_ICON.

Error spammed when opening mailbox (with 4 recovered items from Postmaster and Thaumaturge)

824x CT_MailMod\CT_MailMod_MailLog.lua:330: attempt to perform arithmetic on local 'olderExpires' (a nil value) [string "@CT_MailMod\CT_MailMod_MailLog.lua"]:330: in function <CT_MailMod\CT_MailMod_MailLog.lua:309> [string "@CT_MailMod\CT_MailMod_MailLog.lua"]:422: in function logFunc'
[string "@CT_MailMod\CT_MailMod_MailLog.lua"]:376: in function logPending' [string "@CT_MailMod\CT_MailMod_MailStructure_Incoming.lua"]:277: in function retrieveSelectedMail'
[string "@CT_MailMod\CT_MailMod_MailStructure_Incoming.lua"]:1176: in function action' [string "@CT_MailMod\CT_MailMod_MailActions.lua"]:236: in function key'
[string "@CT_MailMod\CT_MailMod-9.1.0.3.lua"]:99: in function <CT_MailMod\CT_MailMod.lua:94>

Locals:
self =

Issue: When gaining a new ability, such as a covenant ability, the drag-icon does not stop until it is placed on one of the action bars corresponding to the original Blizzard multi-action bar.

Since the update 2 days ago, constantly getting this error upon logging into a character:

Couldn't open CT_Library\

The Null Barrier buff is showing under "Uncancelable buffs" instead of regular buffs. There is no option to force it to display as a standard "cancelable" buff. I've also checked for a way to manually specify which category buffs fall under, but cannot find where to set it. Please see screenshots for a demonstration and Buff Settings.

Thanks for your time, and great mods! I've used CT since TBC. By far one of the most helpful mod's I've ever used!

Cheers,

Ref: https://www.curseforge.com/wow/addons/ctmod?comment=1197

Issue: QuestLogQuests_AddQuestButton is no longer global, so the prehook in CT_Core no longer functions.

Background: 9.0.1 introduced Chromie Time, requiring some changes to how the quest log entries are generated. Blizzard used this opportunity to rebuild the functions and make them locally scoped.

Issue:

• New CT users cannot generate an export string until they have at least two toons (ie, profiles) on an account.

Details:

• Historically, this was an intentional feature because "settings import" wasn't possible unless there was at least one other profile to import from.
• Now that settings can be exported there is no need to hide the addon list and actions when players are logged onto the only profile.
• It is still necessary to handle the case that a profile is 'empty' having no configurations to export.

References:

• https://www.curseforge.com/wow/addons/ctmod/?comment=1082

Problem:

• CT_BuffMod does not provide any border around buff icons, appearing different from the default UI.

Possible Solution:

• Provide an option to use reuse the default UI's border texture, with backwards compatibility from 9.0 to Classic.

Discussion:

• Borders are changing in WoW 9.0

References:

• https://www.curseforge.com/wow/addons/ctmod?comment=951

Issue: Beginning in Battle for Azeroth, some raid encounters have cinematics during combat between phases. These cause the Cinematic Frame to override the custom WorldFrame position, and CT_Viewport is unable to recover because of combat lockdown.

Examples:

• Jaina freezing the sea (8.1)
• The mythic-only room in N'Zoth (8.3)

Suggested solution:

/run CinematicFrame:SetScript("OnShow", nil) 
/run CinematicFrame:SetScript("OnHide", nil)

Reference: https://www.curseforge.com/wow/addons/ctmod?comment=923

TBC Classic Beta

CT_BarMod and CT_BottomBar are inoperable, possibly due to Stanzilla/WoWUIBugs#66

CT_BuffMod can operate in non-secure mode only.

Issue: Custom CT_BarMod action buttons do not apply the 'glow' effect when assigned a macro action.

Details:

• Default UI action buttons show a glow effect on action buttons when an ability triggers, including when the ability is referenced by a macro.
• CT_BarMod action buttons do show the glow effect when the spell is assigned to the slot, but not when it is a macro.

References:

• https://www.curseforge.com/wow/addons/ctmod?comment=962

Problem:

• Blizzard is changing the backdrop borders in 9.0

Suggested solution(s):

• Inherit the new BackdropTemplate in 9.0 (but not yet Classic or BFA); or
• Custom-code the border templates to circumvent dependence on backdrops for all versions

Discussion:

• A custom-code solution might be an opportunity to resolve #49 (comment)

Something in the latest update has caused the CT_ViewPort Options to reset. I see the behavior on multiple characters. When I login, the settings have been reset. Sometimes when I logout and login to the same character in the same session (without leaving the application), they seem to 'stick' but not always.

It doesn't take long to setup when they reset but it's certainly a pain. Hoping you can find the cause quickly so I don't have to revert back to a prior version. Thanks!

When moving the quest Objectives Tracker window to another location of the screen it will reset back to the stock position in a few seconds while doing various activities. Switching off then back on the "Enable these options" button makes the objective tracker to move to the desired location again, but only for a few seconds again, then it resets back automatically.

This was a bug during the whole BFA I believe but I was not worried about it because MoveAnything was able to keep the objectives window on the left side of my screen, but in 9.0 MoveAnything doesn't work and causes massive lag, so I have to recline upon CT.

Repeatable error message

Message: Font : Unable to load font file Fonts\arheiuhk_bd.TTF
Time: Sun Mar 14 23:48:30 2021
Count: 4

Searching addons folder, I can only find this in one of your xml files.

Issue: After dramatic improvements to other CT modules, CT_Core sticks out as a CPU hog while sitting idle.

Root Cause:

• CT_FCF_OnUpdate() was checking every frame to see if any custom CT_Core chat frame handles were being used to resize a chat frame; and then it would prevent the chat frame's other components from fading out during resizing.

Solution:

• Start a timer (using C_Timer) only when a custom CT_Core chat frame handle is being used.

After every login or reload, i can see the macro names. Only if i put the cursor on the macro, the names disappear. If i use a spell or any macro the name of the macro comes back.

I`m using the standart blizzard action buttons.

All in all the function: <"blizzard action buttons - Apply the Display macro names option"> doesnt work any more since the last few updates.

Issue: Players with tons of alts have long drop-down lists in the Settings Import tab

Possible Solutions:

• Provide a 'check all' button to select all AddOns with a single click, allowing for faster profiles
• Enable 'linking' or 'synchronizing' profiles so that many alts share the same settings

References:

• https://www.curseforge.com/wow/addons/ctmod?comment=1008

Curse user Asjaskan requests adding a new feature to cast spells on "player" or "focus" unit IDs in response to different types of clicking.

https://www.curseforge.com/wow/addons/ctmod?comment=916

Problem:

• CT raid frames do not touch each other, even when v- or h-spacing are set to zero.

Suggested solution:

• Permit negative spacing to cancel out the effect of borders.

Discussion:

• Frame backdrop borders in 8.0 and earlier will shrink the visible are of the frame, because the borders include a transparent outer edge that expands based on the edge size
• Backdrop borders are changing in 9.0, so this change makes sense to implement in 9.0.0.1

Reference:

• Originally requested at Curse by meltar42.

Message: Interface\AddOns\CT_MapMod\CT_MapMod.lua:70: hooksecurefunc(): FlightMap_LoadUI is not a function
Time: Thu Sep 2 12:19:30 2021
Count: 1
Stack: Interface\AddOns\CT_MapMod\CT_MapMod.lua:70: hooksecurefunc(): FlightMap_LoadUI is not a function
[string "=[C]"]: in function hooksecurefunc' [string "@Interface\AddOns\CT_MapMod\CT_MapMod.lua"]:70: in function Initialize'
[string "@interface\AddOns\CT_MapMod\CT_MapMod.lua"]:1662: in function update' [string "@Interface\AddOns\CT_Library\CT_Library.lua"]:638: in function value'
[string "@interface\AddOns\CT_Library\CT_Library.lua"]:701: in function <Interface\AddOns\CT_Library\CT_Library.lua:697>

Locals:

ZA patch, From Bug Sack:

51x FrameXML\SecureGroupHeaders.lua:1026: attempt to call field 'ForEachAura' (a nil value)
[string "@FrameXML\SecureGroupHeaders.lua"]:1026: in function <FrameXML\SecureGroupHeaders.lua:961>
[string "=[C]"]: ?
[string "=[C]"]: in function Show' [string "@CT_BuffMod\CT_BuffMod-9.1.0.3.lua"]:7257: in function createBuffFrame'
[string "@CT_BuffMod\CT_BuffMod-9.1.0.3.lua"]:7612: in function createBuffFrame' [string "@CT_BuffMod\CT_BuffMod-9.1.0.3.lua"]:7627: in function createWindow'
[string "@CT_BuffMod\CT_BuffMod-9.1.0.3.lua"]:7915: in function `addWindow'
[string "@CT_BuffMod\CT_BuffMod-9.1.0.3.lua"]:10280: in function <CT_BuffMod\CT_BuffMod.lua:10237>
[string "@CT_BuffMod\CT_BuffMod-9.1.0.3.lua"]:10327: in function <CT_BuffMod\CT_BuffMod.lua:10325>

Locals:
self = CT_BuffMod_AuraFrameSP1 {
0 =
weaponButtons =

Issue: Shadowlands introduces new map waypoints and provides an API for addons to interact with them.

Details:

• There is a user-selectable waypoint by ctrl-clicking on the map.
• Shift-clicking the waypoint adds it to a chat message to share using a new waypoint hyperlink

Planned changes to CT_MapMod:

• Change the editing keybind to make room for the new UI
• Respond to ctrl-click on a MapMod pin, placing the waypoint right atop its location
• Create hyperlinks to share CT_MapMod pin locations in chat messages
• When creating notes over a waypoint, place it exactly on the waypoint's coordinates

Since the last update (9.0.5.3 SL on retail), the XP bar pops up on the top left corner of the screen for no reason while playing. (it's not there when logging in)
It looks like the XP bar that I've left at it's default size and position. (xp bar hidden because maxlvl on the screen, but happens also on alts that are not maxed)

Hiding / enabling it from the options doesn't change a thing.
The bar cannot be moved.

/reload removes it but it still comes back sometimes.

I'm not 100% sure but it pops when interactinf with flypath

I play a Shaman in WoW Classic and ever since the last Classic update the buff bar seems to have issues with expired buffs. This is most noticeable with my totems. They last for 1-2 minutes and I get an an aura when in range of them.

In the past when the totems despawned the aura would drop off the Buff mod, but that no longer seems to occur.

I think normal buffs are turning to a black square when they expire. However, I haven't played in a few days so that may not be right.

I'm not getting any LUA errors, it just doesn't seem to be updating properly.

I can try to take some screen shots this weekend when I play again if that's helpful. I mostly came to see if there as an existing Bug report, but it doesn't appear to be so I thought I should submit something before I forget again.

Hello

When I have CT BarMod enabled, my stance bar is moved way above my action bars, like in this picure: https://i.imgur.com/3NT1vMU.png

When i disable BarMod it looks like this: https://i.imgur.com/hApaMH1.png

I havent found a way to move the stance bar in the addon

version 9.1.5.1 BCC

Message: Interface\AddOns\CT_Library\CT_Library.lua:173: invalid option in format' Time: Thu Feb 3 19:18:27 2022 Count: 2 Stack: Interface\AddOns\CT_Library\CT_Library.lua:173: invalid option in format'
[string "=[C]"]: ?
[string "@interface\AddOns\CT_Library\CT_Library.lua"]:173: in function errorformat' [string "@Interface\AddOns\CT_MailMod\CT_MailMod_MailLog.lua"]:310: in function printLogMessage'
[string "@interface\AddOns\CT_MailMod\CT_MailMod_MailStructure_Incoming.lua"]:564: in function <...Ons\CT_MailMod\CT_MailMod_MailStructure_Incoming.lua:547>
[string "@interface\AddOns\CT_MailMod\CT_MailMod_MailStructure_Incoming.lua"]:748: in function deleteSelectedMail' [string "@Interface\AddOns\CT_MailMod\CT_MailMod_MailStructure_Incoming.lua"]:1232: in function action'
[string "@interface\AddOns\CT_MailMod\CT_MailMod_MailActions.lua"]:236: in function `key'
[string "@interface\AddOns\CT_MailMod\CT_MailMod.lua"]:99: in function <Interface\AddOns\CT_MailMod\CT_MailMod.lua:94>
Locals: (*temporary) = "'21%', From Xdebank @ Gehennas: Deleting mail."

Not trying to be pushy, but I got to ask...10 months since last update...has me wondering...has this project been abandoned by the owner?? I hope not as it has been an essential part of my WoW setup for years. Please provide some kind of feedback as to the status. Thank you!

Lots of herbs and ore have got old icons on the map. Is it possible to add icons (I to not know where to get the .tga files from) for these? Thanks

Issue: CT_RaidAssist does not display health percentages as text.

Ideas to consider:

• Provide similar formatting options as CT_UnitFrames
• Accommodate special boss auras appearing over the health bar
• Accommodate health bars appearing as a background

Reference: https://www.curseforge.com/wow/addons/ctmod?comment=1046

Tossing tons of errors on Dragonflight Beta. (43 different errors.)

Maybe I am using the wrong one so let me know when the new one comes out.

It would be nice if the different sub-modules were grouped when using addons like Addon Control Panel. This can be done by simply adding the line:

## X-Part-Of: CTMod

to the toc manifest file of each module. (Or whatever other name you want to have be the main heading)

Issue: The mail log doesn't clearly show the quantity of items sent as a stack.

Details:

• Quantities are tracked and shown in the tooltip, but this doesn't allow for quick "at a glance" viewing.

References:

• https://www.reddit.com/r/classicwow/comments/ikjhsr/looking_for_an_addon_that_records_incoming_mails/g3m4sml/?utm_source=reddit&utm_medium=web2x&context=3

Problem:

• The tooltip anchor updates its position perceptibly slower than the screen refresh rate

Suggested solution(s):

• Accelerate the ticker from every 0.06 sec to every 0.03 sec

Discussion:

• The 0.06 sec ticker translates into a rough 15fps, versus traditional film at 24fps
• When moving the mouse across the screen, this is slightly perceptible as a sort of lag or stutter
• Accelerating to 0.03 sec ticker translates into a rough 30fps
• If 0.03 sec is found to still be insufficient in testing, then consider alternatives to a ticker

You recently made some changes regarding my issue #95

Since I downloaded the update, much of the text in chat is clipped along its lower aspect (I use 16 Font Size)
Also much text in dialog boxes is distorted, partially shaded (difficult to describe).

The bid price is 11

See warrior in the above clip, and clipping of reasonable.

If I revert to the previous version, apart from the error, all seems good.
Sorry.