dd4t / dd4t.mvc Goto Github PK

If a component presentation is dynamic (in other words: loaded directly from the broker, not from the page), the IsRepositoryPublished and IsQueryBased are both set to true by the XpmMarkupService. This is not correct, because CPs can be dynamic without being query-based. This is the case when a component template is marked as 'publish as a dynamic component' but also 'allow to be embedded on a page'.
As a result, a DCP which is embedded on the page cannot be moved around, like you can with a completely static CP.
To solve this, we probably need to add an overload to the StartXpmEditingZone, because by looking at the viewmodel it isn't possible to tell if it was created as a result of a query.

If you fail to configure Controller or Action in the app settings, or in your component template, the DefaultComponentPresentationRenderer throws an argument exception. This could be improved by a more explicit exception

This is visible when we have some white area in the image, open below image in IE then you can understand better, because in Chrom we have default black area and it cannot be visible.

Entities can be based on component presentations, but also on embedded fields or linked components. If a view developer (accidentally) tries to start an editing zone for an entity which is not a component presentation, an error is thrown.

Right now, the page markup has to be written out very differently from component and field markup. Let's align this.

When a binary is requested using the BinaryDistributionModule or through a BinaryController, the path in the request is temporarily rewritten to /BinaryData/*. At the end of a successful request, it is rewritten again to the original path. But when the request is not successful, e.g. when the binary cannot be found in Tridion, the path in the request stays on '/BinaryData...'. Although you don't notice this in the browser (it is a server-internal process), you do notice it if you have other handlers / modules in the pipeline which do something with the request. One example is a Friendly Url module, which looks up '404' requests in a list of friendly url definitions.
We need to make sure the path is always reset to the original, even if the binary cannot be found.

If a user requests a URL with double slashes (like http://www.acme.org//my//page.html), the URL should be normalized (into http://www.acme.org/my/page.html) before it is requested from the broker API. This is standard behaviour of most web servers.
This should become part of the 'add welcome file' logic in the DD4TControllerBase.

Optionally we could add support for extensionless urls as well.

If you call StartXpmEditingZone on a model that represents a linked component (rather than a component presentation), an empty string is returned. This is a shame because Tridion allows you to edit fields inside linked components if you just add a (nested) ComponentPresentation XPM comment. The template part is simply ignored.
To solve, we need to overload the StartXpmEditingZone with a parentModel (an IViewModel which contains a component template).

The code here:
https://github.com/dd4t/DD4T.MVC/blob/develop/source/DD4T.Mvc/Html/TridionHelper.cs#L99

is clearly intended to ensure that a non-null value of 'page' is passed to

MvcHtmlString output = renderer.ComponentPresentations(page, helper, byComponentTemplate, bySchema);

at line 115.

The assumption is that evaluating: helper.ViewContext.Controller.ViewBag.Page will throw if no page is available ,however it can simply evaluate to null without throwing.

Steps to reproduce:

• Make sure you have a published binary (e.g. /Images/test_tcm3-123.png)
• Make a request with a browser to /Images/test_tcm3-123.png/
• A FOLDER called test_tcm3-123.png is now created
• Subsequent requests to the correct url (/Images/test_tcm3-123.png) will fail because the folder is in the way

Class should contain the defaults that will be set by on of the DD4T.DI.*

Example:

var mappings = new Dictionary<Type, Type>();
mappings.Add(typeof(IMessageProvider), typeof(JMSMessageProvider));

return mappings;

In DD4T.Mvc\ViewModels\XPM\Contracts.cs, the namespace is defined as
DD4T.MVC.ViewModels.XPM

This is inconsistent with the namespacing scheme used in the rest of DD4T, where 'Mvc' is used rather than 'MVC'