Hi, thanks for the library. I am having problems with string encodings, see this e

fixed for my use-case with <a class="issue-link js-issue-link" data-error-text="Failed

Text encoding, how to do it? about dcmjs HOT 2 OPEN

dcmjs-org commented on June 6, 2024

Text encoding, how to do it?

from dcmjs.

Comments (2)

vsaase commented on June 6, 2024

I think the problem is here, strings are read byte by byte, which is not compatible with utf8:

dcmjs/src/BufferStream.js

Lines 214 to 225 in 168a954

    
           readString(length) { 
        
               var string = ""; 
        
               var numOfMulti = length, 
        
                   index = 0; 
        
               while (index++ < numOfMulti) { 
        
                   var charCode = this.readUint8(); 
        
                   string += String.fromCharCode(charCode); 
        
               } 
        
               return string; 
        
           }

from dcmjs.

vsaase commented on June 6, 2024

fixed for my use-case with #92

from dcmjs.

Related Issues (20)

[mutiple Qs]: convert .jpg to .dcm, no dicom header, could't not find declaration module ''dcmjs",... HOT 5
DicomMessage.readFile failes if GroupLength parameter is wrong calculated HOT 4
use SegmentNumber from the segment metadata exporting DICOM SEG. HOT 6
US cine loops with Transfer Syntax RLE Lossless are corrupted after DicomMessage.write when fragmentMultiframe option is enabled HOT 5
anonymizer uses incorrect tag names HOT 1
The saved image file is inconsistent with the source file. HOT 9
private Tags take element wrong into account HOT 1
Segmentation loading with wadors not working HOT 1
dcmjs-imaging HOT 2
Invalid tag in sequence : Unable to parse MR Dicom file in dcmjs. Cornerstone able to parse and works fine HOT 1
Order of tags gets messed up when edition DICOM SEG HOT 5
Length of Decimal String larger than 16 characters
Lots of 'Invalid vr type... ' log messages in dcmjs release 0.29.11 HOT 4
modifying dicom meta-data HOT 2
Reading dicom file HOT 1
Getting ERROR: Value exceeds max length for some DICOM tags HOT 2
Write issue for JPEG2000Loseless images HOT 3
Issue with pixel redaction for JPEGLoseless type HOT 1
Change in PixelSequence value HOT 1
Support for reading from a readable stream HOT 1

Text encoding, how to do it? about dcmjs HOT 2 OPEN

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	readString(length) {
	var string = "";

	var numOfMulti = length,
	index = 0;
	while (index++ < numOfMulti) {
	var charCode = this.readUint8();
	string += String.fromCharCode(charCode);
	}

	return string;
	}