Order of tags gets messed up when edition DICOM SEG about dcmjs HOT 7 OPEN

Sample original and edited files
orj_editedlocal.dcm is the file created by using the code snippet given above
edited_by_epad.dcm is the file created by ePAD using a similar code to the code snippet given above

from dcmjs.

@pieper any ideas?

from dcmjs.

Hi @emelalkim thanks for your patience - I think the issue is that MediaStorageSOPInstanceUID is only supposed to be in the part10 (dicom file) metaheader and not in the dataset itself.

In dcmjs that's stored in the _meta field in the the javascript object, like in this code that parses a part10 from an array of bytes. Let me know if that approach solves the issue.

from dcmjs.

Hi @pieper, thank you for the feedback
I tried modifying the code as below but it doesn't edit the MediaStorageSOPInstanceUID now

const fs = require("fs");

const filePath = "/Users/ealkim/bra45-4510-413-ser/orj.dcm"

let arrayBuffer = fs.readFileSync(filePath).buffer;

let DicomDict = dcmjs.data.DicomMessage.readFile(arrayBuffer);

const dataset = dcmjs.data.DicomMetaDictionary.naturalizeDataset(DicomDict.dict);
dataset._meta = dcmjs.data.DicomMetaDictionary.namifyDataset(DicomDict.meta);
    
dataset.SeriesInstanceUID = '2.25.23542678765445654764635245765';
dataset.SOPInstanceUID = '2.25.23542678765445654764635245769';
dataset._meta.MediaStorageSOPInstanceUID = '2.25.23542678765445654764635245769';

DicomDict.dict = dcmjs.data.DicomMetaDictionary.denaturalizeDataset(dataset);

let new_file_WriterBuffer = DicomDict.write();

fs.writeFileSync("/Users/ealkim/bra45-4510-413-ser/orj_editedlocal2.dcm", Buffer.from(new_file_WriterBuffer)); 

Am I doing it wrong?
And I think it is actually about the data itself. I mean '2.25.23542678765445654764635245769'. There is no issue with ones 1.3... something. I believe it should be valid DICOM UID. What do you think?

from dcmjs.

Hmm, either 2.25.xxx or 1.3.xxx should be fine. There are rules in the standard about what's allowed in these strings of numbers but software like dcmjs shouldn't care. (We use the 2.25 form since it's considered to be the correct way to prefix a random number, while the 1.xxx forms are related to registered prefixes).

In addition to

DicomDict.dict = dcmjs.data.DicomMetaDictionary.denaturalizeDataset(dataset);

Maybe you need to add

DicomDict.meta = dcmjs.data.DicomMetaDictionary.denaturalizeDataset(dataset._meta);

?

If it's still a problem the code to write the data shouldn't be too hard to trace through.

from dcmjs.