Code Monkey home page Code Monkey logo

Comments (5)

pieper avatar pieper commented on May 26, 2024 1

I'm afraid it's more complicated than that...

If you are looking at Tag Description on a system that doesn't know about your private tag (it isn't in the receiver's dicom data dictrionary) then it has no way of knowing the description. Private tags are ones where the group is an odd number and for yours the group is 0009, so by default nobody but you knows what the values mean. The most it can do is display the text.

Plus, adding private tags is more complex than just adding them to the dataset. You can google for the details, but here's a place to start.

Once you understand how it should be laid out, you can create the required elements with dcmjs. You have a look at the discussion here about adding standard elements to the dataset: #64

from dcmjs.

Subashree01 avatar Subashree01 commented on May 26, 2024

@pieper
I have another Question, whenever I tried to write the tag datas inside the DICOM file using dcmjs npm. Private Tags are added correctly but I can see that the rest of the tag datas are getting modified. Not all tag datas (But some datas which doesn't hold values or some Tag datas which has numeric has its value ). The tag length and VM Value is getting changed. Even though I am not writing any code to modify the existing Tag details rather than inserting a new one.

From the below Tags you can see the tags which holds 0 is taking as empty spacae and also wherever the tag value is numeric those datas are modified to empty space and the length as 0

Original Tags
goupelement Tag Desc. VR VM len Value
(0010,1020) PatientSize DS 1 2 0
(0010,1030) PatientWeight DS 1 2 0
(0018,0022) ScanOptions CS 1 6 HELIX
(0018,0050) SliceThickness DS 1 2 2

Modified After a Write Operation:
goupelement Tag Desc. VR VM len Value
(0010,1020) PatientSize DS 0 0
(0010,1030) PatientWeight DS 0 0
(0018,0022) ScanOptions CS 1 6 HELIX
(0018,0050) SliceThickness DS 0 0

(0021,0010) PrivateCreator ST 1 14 [email protected] --> Newly added Private Tag

from dcmjs.

pieper avatar pieper commented on May 26, 2024

Sounds like this is related to your questions in #90. Your testing is very helpful, so we should try to get this sorted out. Can you try creating a simple example script + dataset to use for debugging?

from dcmjs.

rvantklooster avatar rvantklooster commented on May 26, 2024

Should be fixed by the merge of #96

from dcmjs.

saikrishnaksbs avatar saikrishnaksbs commented on May 26, 2024

How to add private tags to existing dicom istance using api call?

from dcmjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.