Release cycle/notes about dcmjs HOT 7 CLOSED

Going to re-open this. Maybe I'm spending too much time over in OHIF/Cornerstone land 😅

It looks like, despite having CI in place, it's not quite doing the trick. I'll consider this an issue advocating for it to be fully implemented. See recent merge PRs:

https://app.circleci.com/jobs/github/dcmjs-org/dcmjs/95

It cut a "flagged" release for the wrong version: v0.9.0-build-95

We may have put that in place as a temporary measure to quickly test new builds

from dcmjs.

👋 Hi @jody-zeitler!

This repository has automatic release/versioning (and tagging) via CircleCI + Semantic Release. For that to trigger/work, commits (or merge commits) need to use the correct syntax, see:

https://semantic-release.gitbook.io/semantic-release/#commit-message-format

Unfortunately, it looks like on the last few merges, we did not update the merge commit to use the correct syntax for the changes that took place. I wouldn't be surprised if we also accidentally did a manual release instead of using this system.

I'll revert and reapply some of the recent PRs. Hopefully this addresses this issue. Outside of that, I'm not sure there's much we can do except educate maintainers.

from dcmjs.

Hi @dannyrb could you update the readme with specific instructions? (I must not have been paying attention, because I totally didn't know about or forgot this auto-release thing was set up!)

I have been doing these steps when it I want to update the package:

https://github.com/dcmjs-org/dcmjs#for-maintainers

from dcmjs.

@jody-zeitler thanks for bringing this up, clearly we need to sort this out and get on the same page 😄

@dannyrb can we also turn on testing in the ci?

Would it just be adding -run: npm test after this line?

from dcmjs.

@pieper we can enforce passing tests before merge of a PR is allowed. That would be a separate workflow.

from dcmjs.

Tests now run on PRs:

Semantic versioning via Commit Messages in place:

• CI Workflow: https://app.circleci.com/pipelines/github/dcmjs-org/dcmjs/268/workflows/5eee11a8-6599-4f9e-b7fa-ba98dd6e1c07/jobs/101

from dcmjs.

Awesome thank you!

from dcmjs.