dcbia-ortholab / slicerconda Goto Github PK

One of the nitpick issues mentioned in Slicer/ExtensionsIndex#2006 (review)

Logic classes are CondaSetUpCall and CondaSetUpCallWsl. CondaSetUpLogic is unused, so remove it.

Parameter node is unused - conda settings are persisted in Qt Application settings. I believe this is a correct choice: no conda options should be persisted with the Slicer scene. So remove the logic around parameter node and wrapper.

• def initializeParameterNode
• def setParameterNode
• Logic in exit()
• Logic in enter()
• Logic in onSceneStartClose
• Logic in onSceneEndClose
• class CondaSetUpParameterNode

Sample data is not used, so remove the sample data from the extension template

• def registerSampleData
• Logic in class CondaSetUp

One of the nitpick issues mentioned in Slicer/ExtensionsIndex#2006 (review)

Adopt ruff linter/formatter and pre-commit-hooks from Slicer.

Relevant Slicer config files to add:

ruff config at https://github.com/Slicer/Slicer/blob/main/.ruff.toml

pre-commit config at https://github.com/Slicer/Slicer/blob/main/.pre-commit-config.yaml

GitHub actions to automatically run pre-commit at https://github.com/Slicer/Slicer/blob/main/.github/workflows/lint.yml

One of the nitpick issues mentioned in Slicer/ExtensionsIndex#2006 (review)

Make the conda installation functions installConda into __private methods so it is clear they shall not be called by third-party code.

The only way to install anything to system should be via the CondaSetUp module UI, or by manually installing a distribution and setting its path. Making these methods private will ensure, or at least make obvious, that other modules shall not automatically install conda distributions without user input.

One of the nitpick issues mentioned in Slicer/ExtensionsIndex#2006 (review)

To avoid confusion, delete the upstream project https://github.com/GaelleLeroux/SlicerConda and re-fork the one hosted in this DCBIA-OrthoLab organization.

This will make the DCBIA-OrthoLab organization's repository the upstream and unambiguous source of truth moving forward.