dbrekalo / wheninviewport Goto Github PK

Hello there. I just started toying around with this plugin. Please bare with me as I am just getting into javascript. I notice that when I do canvas orientation change that many times the wheninview events do not fire.

I'm using this code from the example project which works perfect except when I rotate canvas on a mobile device.

;
$(function() {
    var WhenInViewport = window.WhenInViewport;

    $('.brick').whenInViewport(function($brick) {
        $brick.addClass('animate');
    });
});

Hi there,

I'm working on an infinite scroller using this library, where more content is loaded once you scroll to the bottom. Great library, btw, it works perfectly on both desktop and phone, and was painless to setup.

But, I'm noticing an issue where my scroll handler is called once on first being created, then once when you actually scroll to the bottom, but then it never gets called again and more content isn't loaded.

I dug through the code, and in node_modules/when-in-viewport/src/whenInViewport.js, commenting out the following function:

removeItem: function(registryItem) {

            delete this.store[registryItem.storeKey];

        },

fixed the issue. So it looks like each time when the callback is triggered, the event itself is removed from the registry so it isn't triggered again.

Any ideas why this is? I'm happy to submit a pull with a fix if needed.

I installed using npm install as per your documentation, and I'm using this in a vue-js project, via:

import WhenInViewPort from 'when-in-viewport'
this.viewPortHandler = new WhenInViewPort(this.$el, this.handleScroll)