dazkind / linc_bgfx Goto Github PK

The function requires 3 parameters in BGFX:
setViewName(viewId, name, length) with types (ViewId, const char *, int32_t)

The externs don't give the string length to the function.

Expected:

Actual output:

This causes the build to fail.
I have not checked if there are other functions with the same problem.

Description
There is a problem with NanoVG where certain fonts are unable to be unloaded.
Let's say I load a font called font1, then load another font called font2.
At this point stash->nfonts will be 2
If I now unload font1 stash->nfonts will be 1 again.
This means that font2 cannot be unloaded as there is a check in place (idx >= stash->nfonts)
I've confirmed this is the problem by trying to unload them in reverse order (font2, font1 instead of font1, font2) which made the problems disappear.

To Reproduce
Steps to reproduce the behavior:

1. Load 2 or more fonts
2. Unload the first font
3. Try to unload the second font, the call to do this will return false.

Expected behavior
When you attempt step 3 of the reproduction steps, you should be able to unload the font and the function should return true.

Proposed solution
Instead of checking if idx >= stash->nfonts is true, possibly check if the font at the specified index is a nullptr, with perhaps some additional sanity-checks like idx >= FONS_INIT_FONTS

Additional details
Outside of the code added to this fork to free the font, there is also a problem with finding fonts. As it uses a for-loop for finding the fonts, where sometimes a font might be outside of the range of the font

The generated enum:

Expected enum:

It seems like the enum is being generated incorrectly.
I have not verified if this is the case with other enums, so far this is the only enum with problems that I've found.
If I see other broken enums I'll report that here.

With kind regards,
http80