davidvujic / clojurescript-amplified Goto Github PK

This might be an issue, example here:
https://github.com/DavidVujic/clojurescript-amplified/blob/main/src/stories/app/stories/avatar_stories.cljs#L8

and the helper function here: https://github.com/DavidVujic/clojurescript-amplified/blob/main/src/stories/app/stories/helper.cljs#L9

If I understand the reagent docs correctly, the component that is passed in to reactify-component should only have one argument.

This issue appear when I try to run watch-with-amplify

[2021-09-11 11:17:11.055 - WARNING] :shadow.cljs.devtools.server.util/handle-ex - {:msg {:type :start-autobuild}}
AssertionError Assert failed: (map? rc)
shadow.build.resolve/maybe-babel-rewrite (resolve.clj:205)
shadow.build.resolve/maybe-babel-rewrite (resolve.clj:205)
shadow.build.resolve/fn--11782 (resolve.clj:414)
shadow.build.resolve/fn--11782 (resolve.clj:405)
clojure.lang.MultiFn.invoke (MultiFn.java:244)
shadow.build.resolve/find-resource-for-string (resolve.clj:80)
shadow.build.resolve/find-resource-for-string (resolve.clj:69)
shadow.build.resolve/resolve-string-require (resolve.clj:452)
shadow.build.resolve/resolve-string-require (resolve.clj:435)
shadow.build.resolve/resolve-require (resolve.clj:672)
shadow.build.resolve/resolve-require (resolve.clj:665)
shadow.build.resolve/resolve-deps/fn--11696 (resolve.clj:51)

:npm-module takes an optional :ns-regexp which will make it include all namespaces matching that regex. You can use this to completely skip createing the app.stories.core ns and just include them all automatically.

Instead of that you add :ns-regexp "-stories$" and remove :entries and the app.entries.core ns. Less config maintenance over time ;)

If I clone master of this repo and do

npm install
npm run watch-with-amplify

The shadow-cljs run gets a warning and doesn't build the js modules for the app-with-amplify

The build output:

 npm run watch-with-amplify

> [email protected] watch-with-amplify
> shadow-cljs watch app-with-amplify stories

shadow-cljs - config: /Users/rberger/work/aws/clojurescript-amplified/shadow-cljs.edn
shadow-cljs - HTTP server available at http://localhost:8080
shadow-cljs - server version: 2.16.4 running at http://localhost:9630
shadow-cljs - nREPL server started on port 64363
shadow-cljs - watching build :app-with-amplify
shadow-cljs - watching build :stories
[:app-with-amplify] Configuring build.
[:stories] Configuring build.
[:app-with-amplify] Compiling ...
[:stories] Compiling ...
[2021-12-20 23:55:33.193 - WARNING] :shadow.cljs.devtools.server.util/handle-ex - {:msg {:type :start-autobuild}}
AssertionError Assert failed: (map? rc)
	shadow.build.resolve/maybe-babel-rewrite (resolve.clj:205)
	shadow.build.resolve/maybe-babel-rewrite (resolve.clj:205)
	shadow.build.resolve/fn--11790 (resolve.clj:414)
	shadow.build.resolve/fn--11790 (resolve.clj:405)
	clojure.lang.MultiFn.invoke (MultiFn.java:244)
	shadow.build.resolve/find-resource-for-string (resolve.clj:80)
	shadow.build.resolve/find-resource-for-string (resolve.clj:69)
	shadow.build.resolve/resolve-string-require (resolve.clj:452)
	shadow.build.resolve/resolve-string-require (resolve.clj:435)
	shadow.build.resolve/resolve-require (resolve.clj:672)
	shadow.build.resolve/resolve-require (resolve.clj:665)
	shadow.build.resolve/resolve-deps/fn--11704 (resolve.clj:51)
[:stories] Build completed. (436 files, 0 compiled, 0 warnings, 3.33s)

Any idea what's up? I presume this did work. The only things I could think is different is I'm running node v17.2.0. Otherwise everything else is set by the package.json and the shadow-cljs.edn which are unchanged from the repo.