Comments (3)
I don't see why channels can't be made public as you proposed in your PR
from swiftphoenixclient.
This is a behavior in the phoenix js client that SwiftPhoenixClient is porting. I'm not sure why that behavior was decided upon.
I believe that the reasoning is because the leave push is stored in the message queue and will be sent to the sever once the connection is established. The client assumes that leave will be successful and allows the app the discard the channel since that's really the only thing to do after a channel is left. It's likely an optimization to prevent potentially waiting for an internet connection to simply close a channel.
from swiftphoenixclient.
The client assumes that leave will be successful and allows the app the discard the channel
Is this a safe assumption? If so, then I think this PR should unblock my use case.
from swiftphoenixclient.
Related Issues (20)
- Move out additional Rx and Starscream solutions to separate Swift Packages HOT 9
- Question: Behaviour when remote kills connection. HOT 3
- How to configure heartbeat? HOT 4
- Problems with connections closing and not re-establishing HOT 4
- Access raw message data HOT 2
- Crash on channel connection HOT 1
- `Channel` `bindingsDel` array is not thread safe and appears to rarely cause a crash HOT 1
- Problems with connections on WatchOS 9 HOT 4
- Question: How do I know a socket was successfully opened? `isConnected` seems to say whether or not the handshake took place, not whether the socket was actually opened. HOT 13
- Error: "Undefined symbol: _$s18SwiftPhoenixClient7ChannelCMn" HOT 11
- SSL Pinning support after StarScream removal HOT 3
- Crash in `Channel.swift` `off()` function HOT 2
- Crash in `Socket.append<T>(callback:to:)` function HOT 5
- Sending binary data in a message HOT 3
- Crash on Channel initialization HOT 4
- Version 5.3.1 is unavailable via cocoapods HOT 1
- Adding a certificate authentication request HOT 1
- Socket.sendHeartbeat() EXC_BAD_ACCESS (KERN_INVALID_ADDRESS) HOT 2
- What are the payload size limits? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swiftphoenixclient.