Move out additional Rx and Starscream solutions to separate Swift Packages about swiftphoenixclient HOT 9 CLOSED

@thehavre @JetForMe version 5.0.0 has removed RxSwift and Starscream as dependencies. These extensions will be available in separate repositories

from swiftphoenixclient.

This is definitely the intention of how the project is set up. If it's not working this way then I may have a configuration issue in the Package.swift file

from swiftphoenixclient.

So, SwiftPhoenixClient still depends on RxSwift and Starscream, and so still pulls them down. May I suggest breaking out the Rx and Starscream support into separate packages that can be included independently?

It would be perfect and right way to solve any related issue. Updating Rx version was like a half-measurement to solve a consequences :(

from swiftphoenixclient.

@thehavre could you please change your Package.swift to use the fix-package-targets branch and verify it is working for you? Thanks

from swiftphoenixclient.

@dsrees unfortunately, it won't work , cause you have declared Rx and Starscream dependencies in one unified Package.swift

dependencies: [
        // Dependencies declare other packages that this package depends on.
        .package(url: "https://github.com/ReactiveX/RxSwift.git", .upToNextMajor(from: "5.0.0")),
        .package(url: "https://github.com/daltoniam/Starscream.git", .upToNextMinor(from: "3.1.0")),
    ]

It means that you have declared your Product SwiftPhoenixClient with required Product dependencies. My issue arrises when I try to add SwiftPhoenixClient to the Project (not target). Xcode tries to resolve all Project's Packages and finds that it has explicit Package with RxSwift Product dependency and also it has SwiftPhoenixClient Product with dependencies where RxSwift version conflicts with already explicitly added RxSwift dependency.

That's why initially I've asked you to divide Rx and Starscream functionality to separate Packages (not targets), where each package depends on SwiftPhoenixClient package. Unfortunately, targets separation in the product can't resolve this issue :(

I don't know if it's possible to do so to not break existing users support, but if it is, it would be great to do so :)

from swiftphoenixclient.

Hmm.. I was using Moya as an example here, assuming that if you used SPM to use Moya, they wouldn't pull non-used dependencies

I need to update to RxSwift 6.0 anyways so would that solve your problem for now until something else if figured out?

from swiftphoenixclient.

Yeah, updating RxSwift works for me. Thanks 🙃

from swiftphoenixclient.

4.0.0 is released which includes RxSwift 6.x

from swiftphoenixclient.

So, SwiftPhoenixClient still depends on RxSwift and Starscream, and so still pulls them down. May I suggest breaking out the Rx and Starscream support into separate packages that can be included independently?

from swiftphoenixclient.