davidrisch / kicker Goto Github PK

• Group menu lines are not centered
• Too long group names won't be shortened
• Group close button is misplaced

Insert links to the actual pages in the left menu sidenav.

Can not register new users, due to missing id in the phone number input html.
Js script also never checks confirm password input.

The title of a page (in the navbar) often gets wrapped when the window is not wide enough. One example is page/group_creation. This needs to be handled differently: smaller font, truncating with a ellipsis, maybe both?

Please add the following features to html_creator.createHtml():

• A paramter to include a list of js files ['example', ' input_validator' ]
• A parameter to include an arbitary string in the header

Suggestion: Function signature createHtml(html, title, options) where options is a dict with the optinal parameters: js, extra_header

page/join_group is currently using plain html. It should look similar to other pages.

An invalid username/password in page/register_credentials should result in an explanation of the rules. See:

• Add function to sanitize html (server side). Consider using https://www.npmjs.com/package/sanitize-html
• Use that function in queryand queryAsync (src/database). It should escape all strings returned by those function (create a helper function for that). This should be enabled by default, but it must be possible to disable it via a parameter.

Since #76 the navbar requires a logged in user. page/imprint needs to work even without a user. Currently the navbar is disabled for that page.

• If there is a user, the navbar should work normally
• Without a user, there should be a cut down version of the navbar: A title and a link to the login page

Changes to src/player_dropdown broke page/tournament_creation.js

The column 'round_id' in the Match table is wrongly named 'tound_id'.

There should be an edit button for each group in the left menu linking to page/group_edit

Please add an apiPost(data) -> response function replacing this code from js/register_credentials.js

const rawResponse = await fetch('/api', {
    method: 'POST',
    headers: {
      'Content-Type': 'application/json'
    },
    body: JSON.stringify({ // this is the parameter vvv
      action: 'validateInput',
      name: document.getElementById('nameInput').value,
      email: document.getElementById('mailInput').value,
      password: document.getElementById('passwordInput').value
    })
  })

  const content = await rawResponse.json() // return this value

That function should be in a new js file in /js. It should be included in the standard header defined in html_creator.

See #58 (comment) from #58

• Fill the list in the right menu group_select with the real groups from the database
• Clicking should set a cookie, see src/account_util.setGroup() and reload the page

add still missing use cases and diagrams

Adds the imprint (Impressum) page (incl. HTML, CSS and JS).

src/tournament.js should also implement functionality to add rounds to tournaments using the swiss matchmaking system

add the table of tasks to documentation

The submit button on the page group_creation should result in an api call. Tha call should insert into the database.

delete groups

The submits button on the page group_edit should result in an two different api calls. These calls should insert into the database or delete from it.

The matches listed in page/running_tournament should be generated from the database. Especially the matches which are not yet complete are of interest.

page/account is currently using plain html. It should look similar to other pages.

Users can register multiple times with the same username

Password -> Passwort

Text of buttons are shifted.
The top of the first division is on some pages not visible

Parsing the received json correctly is required to handle post requests

Still a spelling error after clicking on ok without entering anything:
Ungültige Email Addresse -> Ungültige E-Mail-Adresse

And in some of the other error messages:
Email -> E-Mail
Password -> Passwort

After logging in successfully a logout button should be included in the sidebar from Task 1.7

add documentation latex documents to the git repository

• in api/create_tournamentthe participants should be saved to the database
• in src/tournament only the participants should be placed in generated matches

The functions in src/tournament should handle 1v1 or 2v2 matches. This will require changes to the database

Correct spelling mistakes on registration page:
Password -> Passwort
Telefonummer -> Telefonnummer
Email -> E-Mail

src/tournament implements functionality to create all matches for 2v2 and 1v1 deathmatch tournaments.
The code will not return correct results if the playernumber validates following constraints:

• number of players % 4 == 0 (2v2 match mode)

• number of players % 2 == 0 (1v1 match mode)

These and other edge cases (0 players, ...) need proper error handling (client and server)

See page/create_join_link

Burger menu does not close.
Burger menu and group selection menu have different styles.