Code Monkey home page Code Monkey logo

Comments (2)

davidderaedt avatar davidderaedt commented on July 19, 2024

Hi Andrew,

Thanks for your message. I agree with a lot of things you said. I admit I was too quick to merge lately, there was a lot of activities around some of my projects. I guess I've just been lazy.

1/design patterns: agreed, but let's take problems,one by one and open specific issues for each specific design problem identified.

2/completely agree, unless it is trivial, I'll now wait a few days before merging.

3/dev branch. I'm not sure about this one. The production build is supposed to go the brackets ext rep, so there already is a separation. What do you think?

from annotate-extension.

ajorquera avatar ajorquera commented on July 19, 2024

Hi David,

It's cool to be part of a project that I can be involve and help. I'm very grateful for it.

  1. For the design we need to think about it. When we come with a proposal we can just open an issue and talk about it as you said. But, I think we should focus object oriented programming instead of procedural.
  2. You are right with the branch, there is already a separation. But, with a new branch people can clearly see the difference between the current version and the new one. Each commit to the master branch should be a new version of the extension and not just a simple modification (unless is urgent). Every version should be one that adds new features and resolves all the issues of the current one. If you give a few days for each pull request you should give more time for updating the extension.

I'm not sure if that's the right way to go. I don't have a lot of experience in this. Maybe I'm adding to much complexity to a small project.

from annotate-extension.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.