davidcelis / sunscreen Goto Github PK

Probably not the best practice to have the StatusMenuController be the CLLocationDelegate. The functionality that grabs the current location to pass to the API should really be in its own class. I could probably just name it something like class CurrentLocation and expose a public instance method called fetch().

Instead of just using NSLog to output to the console, the user should get an NSAlert if they disabled Location Services or denied SunPaper access to their location. Preferably, that NSAlert should have a button to open System Preferences for them so they can fix it.

If the user doesn't have network connectivity, we can't get their current location using Location Services. There could be other reasons the user would want to enter a location anyway, so we should provide a text preference allowing them to enter a location.

Hi,

I'm a user and supporter of this app since 2017. I'm planning on moving to an M1 mac. Is there any information about the compatibility or development? Looks like the app has been abandoned, it's no longer available in the App Store neither.

Once SunPaper is ready for use, add a README that at least points to the Mac App store and has some instructions on how to build it.

Since this is my first time using XCode or writing Swift or writing an OS X App, I have no idea how to to write tests for this sort of application yet. I feel okay about that right now, but sometime soon, add Unit and UI tests.

There's a formula out there to calculate, based on coordinates, the various times of day when the sun will hit certain degrees below or above the horizon. Thankfully, I found a JavaScript implementation that includes varieties of the constants I'll need for civil twilight, sunrise, noon, and sunset:

http://suncalc.net/scripts/suncalc.js

It'd be nice to translate this into Swift and not have to make an HTTP call to api.sunrise-sunset.org

Neither of these things work and I'm not sure why (especially for Photos.app) but this should be possible