davekinkead / reasons Goto Github PK

View Code? Open in Web Editor NEW

17.0 2.0 4.0 7.18 MB

Web based argument mapping tools

Home Page: https://dave.kinkead.com.au/reasons

License: MIT License

HTML 6.99% JavaScript 90.27% CSS 0.65% TeX 1.95% Shell 0.14%

argument-mapping html logic critical-thinking

reasons's Issues

Fix pan bug

When zoomed out, dragging a node leads to weird behaviour.

open test/animate-map.html
zoom out at least 200%
drag a reason around to the extremes

Add touch events

Touch actions ...

double tap on blank canvas to add node and trigger edit mode / dialogue box
double tap node to trigger edit mode / dialogue
add save / delete icons to dialogue box
drag node to touch position
touch and drag on blank canvas to pan map
pinch screen to zoom in / out
something for undo/redo (3 finger) ???

SVG export

Hi @davekinkead !
Do you think it's possible to include in your code a function to save the argument map as SVG (maybe with canvas2svg) ?
Thanks again for your wonderful app!

Example code on readme produces a 0-height canvas element

Clone and NPM install the package
Copy/paste the demo HTML and serve locally
This results in a 0px high canvas element and no errors on the console:

The graph elements are present on the screen if I edit the DOM to give the canvas element height.

Tested on both ff and chrome, on 1.0.0 and the master branch.

review issue: community guidelines

As per openjournals/joss-reviews#1044

Please add text as suggested:
"Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support"

Add canvas pan

A single click & drag on a blank bit of canvas should pan the the map by the pan vector.

When in drag mode, the mouse pointer should offer some affordance like this (bottom left)

cc/ @geoffreyd

Suggesting a new feature : the possibility to edit the color of nodes and edges

Your app is incredible! It's the best argument mapping software I've ever used.
I have a suggestion : would you consider including the possibility to edit the color of nodes and edges?
This would allow distinctions to be made between different types of reasons (weak vs. strong, reasons for / reasons against, …)
Thank you again for your work!

Fix dpr bug in png export

Is there a way to reduce the toDataURL() function by the dpr ratio?

visit test/map.html
keypress 'p'
view new tab (image is 2x size when dpr is 2)

Compatibility warning for IE and old iOS

@geoffreyd - what would be the best way to provide a compatibility warning for non-conforming browsers.

IE & iOS 11.4 and below don't work for me and silently fail.

I was thinking a general try-catch block to trigger on error but then any error would cause a warning even on compatible browsers.

Zoom not working in production

as reported by @davekinkead

Add multi-map capability

Get test/dual-maps.html working so that local CSS can specify size but edit overlay defaults to 100%

review issue: Automated tests

As per openjournals/joss-reviews#1044

Can you explicitly spell out how to run the tests. Ideally I could copy/paste.

Add custom line types

Hiya @geoffreyd

I would like to add custom line types to the display of nodes. The first types should be solid (the current version) and then dashed.

I thought they could be specified in an element.lineType property that is get/set in view.js

review issue. Update installation instructions.

As per openjournals/joss-reviews#1044 Functionality, Installation.

I couldnt get this to work:
https://github.com/davekinkead/reasons#embedding-reasons

I got it to work this the below. Perhaps you want to add an eg div instead of body though.

<html>
<body>
  <script src="reasons.js"></script>
  <script>
    let graph = [
        {id: 'p1', text: "Circular arguments work"},
        {id: 'c1', text: "Circular arguments work"},
        {from: 'p1', to: 'c1', type: "because"},
        {from: 'c1', to: 'p1', type: "because"}
      ]
    Reasons.mapper('body').render(graph)
  </script>
</body>
</html>

Add automatic buffer between nodes

When a node is added or moved, a minimum buffer between them should be applied so that there is no overlap/collision between nodes.

My first thought would be to iteratively move each node away from the map centre by the amount of overlap + some buffer (say 25px).

#pseudocode 
after node add or move
  while map.overlap? 
    nodes.map => node.overlap?
      node.padout

Fix text variable padding bug within node

The wordwrap function is buggy in that depending on which element is focused, a different line count will be generated.

Fix undo/redo history bug

One maybe bug I've found is that the undo stack remembers the panning offset/zoom levels (since these values are being updated on the node x/y's instead of just at draw time ... I'll take a look at moving the scaling/panning value adjustments to the canvas drawing code.

Agree @geoffreyd - the only thing that should be added to history is x&y on node move, not pan or zoom.

Fix resize event.target bug in Firefox

The resize event is attached to window and on scroll, the event.target is the map canvas in Chrome & Safari but resolves to the canvas' parent (mapper.DOM) in Firefox. This means the zoom function doesn't work because return

Any ideas why this is happening @geoffreyd ? should be a very easy fix but I'm stumped!

Fix text highlighter

Hi Geoff,

This feature should do the following:

when embedded, offer medium/theguardian style text highlighter
allow a developer to specify what icons & labels text can be highlighted with
allow a user to unselect/remove highlighted text
save highlighted text in local storage (and eventually backend DB)
load highlighted text from local storage when a user visits that URL
post highlighted text to dev specified URL (default to POST reasons.io/

Happy to change any code but would like the API in lib/reasons.js to remain the same if possible

Add zoom in/out

Hi @geoffreyd

I'd like the mousewheel event (and later pinch/expand) to zoom the map in & out.

The event listener will be in ui.js and then rendered via view.js

Review issue: functionality

As per openjournals/joss-reviews#1044 Functionality, functionality.

on windows, in chrome, I couldn't undo via control-z.

davekinkead / reasons Goto Github PK

reasons's Issues

Recommend Projects

Recommend Topics

Recommend Org