datastax / cass-config-definitions Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 17.0 1 MB

Shell 100.00%

cass-config-definitions's People

Contributors

Stargazers

Watchers

Forkers

weexp cpmcdaniel sbtourist scottbale rocco408 cscetbon swapnilgujrathi1983 isabella232 emerkle826 arun5dgr erparthu hedapriya jsanda miles-garnsey zadeindrajeet

cass-config-definitions's Issues

Add jvm8-clients.options and jvm11-clients.options

For Cassandra 4.0, running nodetool expects either jvm8-clients.options or jvm11-clients.options to be present in /etc/cassandra, but config builder does not have a template for either.

Missing parameters in Cluster Communication section for cassandra

Some parameters are missing for cassandra 3.11.6 while they are present for dse 6.
As an example, those parameters are missing https://github.com/apache/cassandra/blob/cassandra-3.11/conf/cassandra.yaml#L840-L852. The seed_provider class should also be configurable but is set by default to K8SeedProvider.

Allow users to set additional-env-opts

As part of the work being undertaken to integrate with the Datastax CDC connector, it has become clear that we need to be able to instantiate a line as below in the cassandra-env.sh file:

CLASSPATH="$CLASSPATH:/opt/management-api/datastax-mgmtapi-agent-0.1.0-SNAPSHOT.jar"
This PR facilitates this by passing anything set in a new array field cassandra-env-sh.additional-env-opts directly into the cassandra-env.sh.

debuglog-enabled not used in Cassandra logback.xml template

DSE uses it https://github.com/datastax/cass-config-definitions/blob/master/resources/logback-xml/dse/logback-xml-dse-5.1.0.template#L121-L123 but not Cassandra's template.

"required" is not a valid key

Running the latest config-builder tests fails since dec2242 was merged (see stack trace below). It looks like the required key is not valid here:

java.lang.AssertionError: FAIL in  (check-all-definitions) (definitions_test.clj:536)
Property :pick_level_on_streaming_min_sstable_size_bytes in definition :cassandra-yaml v6.8.15 has one or or more invalid attributes: #{:required}
expected:  (empty? invalid-keys)
  actual:  (not (empty? #{:required}))

	at dev.clojurephant.tools.clojure_test_junit4$fn__2763.invokeStatic(clojure_test_junit4.clj:56)
	at dev.clojurephant.tools.clojure_test_junit4$fn__2763.invoke(clojure_test_junit4.clj:54)
	at clojure.lang.MultiFn.invoke(MultiFn.java:229)
	at clojure.test$do_report.invokeStatic(test.clj:357)
	at clojure.test$do_report.invoke(test.clj:351)
	at com.datastax.configbuilder.definitions_test$check_for_invalid_attributes$check_for_invalid_properties_at_level__1398$fn__1421.invoke(definitions_test.clj:536)
	at com.datastax.configbuilder.definitions_test$check_for_invalid_attributes$check_for_invalid_properties_at_level__1398.invoke(definitions_test.clj:536)
	at com.datastax.configbuilder.definitions_test$check_for_invalid_attributes.invokeStatic(definitions_test.clj:542)
	at com.datastax.configbuilder.definitions_test$check_for_invalid_attributes.invoke(definitions_test.clj:524)
	at com.datastax.configbuilder.definitions_test$fn__1482.invokeStatic(definitions_test.clj:655)
	at com.datastax.configbuilder.definitions_test$fn__1482.invoke(definitions_test.clj:628)
	at dev.clojurephant.tools.clojure_test_junit4$test_var.invokeStatic(clojure_test_junit4.clj:87)
	at dev.clojurephant.tools.clojure_test_junit4$test_var.invoke(clojure_test_junit4.clj:84)
	at dev.clojurephant.tools.clojure_test_junit4$run_test$fn__2784$fn__2785.invoke(clojure_test_junit4.clj:97)
	at clojure.test$default_fixture.invokeStatic(test.clj:687)
	at clojure.test$default_fixture.invoke(test.clj:683)
	at dev.clojurephant.tools.clojure_test_junit4$run_test$fn__2784.invoke(clojure_test_junit4.clj:95)
	at dev.clojurephant.tools.clojure_test_junit4$run_test.invokeStatic(clojure_test_junit4.clj:94)
	at dev.clojurephant.tools.clojure_test_junit4$run_test.invoke(clojure_test_junit4.clj:91)
	at dev.clojurephant.tools.clojure_test_junit4$run_suite$fn__2789$fn__2790.invoke(clojure_test_junit4.clj:113)
	at clojure.test$default_fixture.invokeStatic(test.clj:687)
	at clojure.test$default_fixture.invoke(test.clj:683)
	at dev.clojurephant.tools.clojure_test_junit4$run_suite$fn__2789.invoke(clojure_test_junit4.clj:110)
	at dev.clojurephant.tools.clojure_test_junit4$run_suite.invokeStatic(clojure_test_junit4.clj:109)
	at dev.clojurephant.tools.clojure_test_junit4$run_suite.invoke(clojure_test_junit4.clj:102)
	at dev.clojurephant.tools.clojure_test_junit4$_run.invokeStatic(clojure_test_junit4.clj:136)
	at dev.clojurephant.tools.clojure_test_junit4$_run.invoke(clojure_test_junit4.clj:135)
	at dev.clojurephant.tools.ClojureTestRunner.run(Unknown Source)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
	at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
	at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
	at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:412)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
	at java.lang.Thread.run(Thread.java:748)

Need to port definitions tests to one of our OSS repos (possibly this one)

Once upon a time, definitions were only used by LCM so LCM had the tests for definitions. Now definitions are used by both the Cass Operator and LCM. Community members are making PRs against this repo but they have no tests as all the tests are in one of our proprietary repos. These are dark times. We should free our tests from the shackles of LCM so that we can enable members of the community to make contributions.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.