datahighway-dhx / mining Goto Github PK

The current logic doesn't work in https://github.com/DataHighway-DHX/mining/blob/master/contracts/Lockdrop.sol#L153

If a user "locks" some tokens, and the owner of the Lockdrop approves say 60% of their claim,
then in the app it shows 60% Approved, 40% Pending, but there's no way to indicate that the vote on their claim is finalised, such that the pending amount becomes rejected. And the logic is wrong.

Instead of just having approvedTokenERC20Amount, we should have a boolean claimVoteFinalized flag or similar, that when set to true prevents further voting on that Lock or Signal (i.e. the approved and rejected values are finalised, and if there are any remaining pending values, then they'd become rejected too).
In addition, we need to have separate approvedTokenERC20Amount, pendingTokenERC20Amount, and rejectedTokenERC20Amount.
The sum of them should not exceed tokenERC20Amount, which is the amount of tokens Locked or Signaled

Requires solution to my post here trufflesuite/truffle#2552 (comment)

Important note: This commit 845ff71 is incomplete.
There are some FIXMEs that need resolving:

• 845ff71#diff-fc2de32b6ca1cc4e72684954b1cba8d4R21
• 845ff71#diff-30da1c1ce14469ebff63f78290faba28R30

The API aspect has been put on hold since for MVP it was agreed on 7th April 2020 that the Flutter app for the testnet would just show instructions and only use a front-end web3 library to read and show the state from the Ethereum smart contracts that record the lock and signals (i.e. show the MXC and IOTA-E balance. Excluded from MVP is having functionality to directly lock, signal, and claim from within the app.

Currently the code is from an older version of Web3 instead of the latest web3 version 1.2.5.
Consider replacing web3.js code that is used for testing with ethers.js or Etherlime https://etherlime.gitbook.io/etherlime/ instead.