[Bug]: curl_multi_exec() request failure on 0.94.0 about dd-trace-php HOT 9 CLOSED

Thanks for your prompt feedback @Julian-Louis 😃

Since it appears to have solved the issue, we shouldn't need anything else from you. On my side, I'll do the PR, including this commit, and we'll possibly see for a hotfix 👍

Thanks!

from dd-trace-php.

I have a suspicion that curl reuses connections and thus curl.connect_time is a bad indicator (as it'll be 0 then). We'll have to verify, thanks for the report!

from dd-trace-php.

Hi @sfong22 and @Julian-Louis,

I apologize for the delay. I am happy to let you know that version 0.95.0, including the required fix, has been released. You can find more information about this version on the release notes.

Thank you for your patience! 😃

from dd-trace-php.

Hey @Julian-Louis!

Could you please try out this artifact (from this CI Job) and tell us if it helps with the behavior you're observing? It uses the http_code instead of relying on connect_time to detect curl request failures 😃

PS: To use the artifact, you can replace the link of the installer by the one from the CI Job, which includes the changes 👍

from dd-trace-php.

Hello, I've just tried the artifact and the problem seems to have been solved.
Do you need anything else?

from dd-trace-php.

Thank you @PROFeNoM and @bwoebi !

from dd-trace-php.

I believe the solution implemented by @PROFeNoM and @bwoebi solved some cases but I am still seeing error traces with a non-zero connect time and dynamodb http code is 200 but the trace is displaying as errored. Would it be most appropriate to leave details here or to open a separate issue? What would be most helpful to your team in that report to determine if this is an ongoing issue or expected behavior?

from dd-trace-php.

Hello @sfong22, it seems that the fix is not yet release, so we should be waiting for the next release of this project (0.95.0).
You can look in the milestone (https://github.com/DataDog/dd-trace-php/milestone/161?closed=1).

from dd-trace-php.

@PROFeNoM Thank you for the update!

I had compared the PR closure to the latest release but didn't actually check the release notes.

Thank you guys for your active monitoring of this repository and all your quick replies.

from dd-trace-php.