[Bug]: Laravel Octane traces not showing in dashboard about dd-trace-php HOT 16 OPEN

@sneycampos I don't think OpenSwoole is supported re: #704 (comment)

Also, from the service page click on "Service Info" top right corner. There is a tab "Primary Operation".

from dd-trace-php.

Hello 👋

Do you know if the Trace agent is receiving the traces at all? You can see that by either checking the datadog-agent status, or by looking at the Trace Agent dashboard on the Datadig UI for your corresponding service.

Thanks!

from dd-trace-php.

@PROFeNoM The agent is definitely working, there are other services still reporting traces within that cluster.

There are other operation traces coming from those service pods but not laravel.request. e.g. If php artisan route:cache is run you see that trace and other operations such as:

laravel.event.handle
command_execution
laravel.provider.load

from dd-trace-php.

Hi @s1rc,

I can reproduce it to keep you updated, but I may have found the root cause. I'm working on a fix/Figuring out the best course of action.

I wanted to know: Was there any particular reason you disabled DD_INSTRUMENTATION_TELEMETRY_ENABLED?

from dd-trace-php.

@PROFeNoM awesome, if there's any way I can help let me know.

Re: DD_INSTRUMENTATION_TELEMETRY_ENABLED it's mostly due to company infosec policies for some environments.

from dd-trace-php.

Right, okay. Thanks for letting me know @s1rc 😃

Please try enabling DD_TRACE_SIDECAR_TRACE_SENDER. I started an environment from scratch this morning and reproduced the issue. After trying multiple combinations, enabling this feature fixed the problem. However, I'm still trying to figure out the exact root cause.

Technically, it will send the traces through the sidecar. That's why I was asking about DD_INSTRUMENTATION_TELEMETRY_ENABLED, as telemetry also makes use of the sidecar, and I wanted to make sure there weren't any technical limitations :)

from dd-trace-php.

@PROFeNoM I tried adding DD_TRACE_SIDECAR_TRACE_SENDER and I didn't see any difference. Even enabling DD_INSTRUMENTATION_TELEMETRY_ENABLED in this staging environment it doesn't show any laravel.request traces.

Interesting thing, I notice that now I am seeing traces for artisan octane:start only after the pod is terminated, and that trace has a duration that matches the lifespan of the pod:

from dd-trace-php.

Hi @s1rc 👋

Thanks for your patience.

An issue was attempted to be fixed with #2645. Could you please try out the following artifact (CircleCI Job)?

To use the artifact, if you followed the public doc, then you have to replace the link you were using to download the datadog-setup.php installer script by the one from the artifact and rebuild 👍

Just so you know, I was using the following app to do my tests.

from dd-trace-php.

Hi @PROFeNoM, did some tests using your repository and got the same results

called a few times (100+) the simple endpoint, simple_view and nothing...

The error endpoint getting the exception

from dd-trace-php.

Noticed that in APM > Traces i can see some data

But in APM > Service Catalog has nothing

from dd-trace-php.

Hey @sneycampos, in the service catalog, can you please look for web.request as the operation name?

from dd-trace-php.

Hey @sneycampos, in the service catalog, can you please look for web.request as the operation name?

Ok, now i see :D, there's any way to set web.request as primary operation? laravel.request doesn't see useful for us (customer) i think

Now i'll try to figure out how to work in my application (using alpine images) a few minutes before trying your repository i tried with my app using openswoole/swoole:22.1.1-php8.3-alpine image, installed libgcc but doesn't see any web.request

from dd-trace-php.

Sorry, forgot this message. I will switch to swoole's image and give you a feedback as soon as possible

from dd-trace-php.

Ok, now it works! a great news this working with laravel octane finally 🚀

Hope it is release asap to be used in production

Great work @PROFeNoM!

from dd-trace-php.

Thank you @PROFeNoM , so far with that artifact I am seeing traces under the web.request operation! I will keep testing tomorrow.

I do have follow up questions:

• Is it not possible to still have octane requests under the laravel.request operation if we added config for that? e.g. ENV DD_*
• If the operation name has to be different, will that affect metrics sources? e.g. We are using metrics such as trace.laravel.request.hits.by_http_status on monitors and SLOs, etc. Will we have to change all of those if we are using Octane?

from dd-trace-php.