Comments (4)
Thank you for taking time to keep the lesson up-to-date with the latest changes in scikit-image, @mkcor.
I am concerned that this would introduce inconsistency in the way we are handling imports and might increase cognitive load. In most cases, we are importing some submodule of skimage
rather than the whole thing (by my count, 14 of 19 scikit-image-related imports in the lesson import skimage.<something>
). Aliasing skimage
to ski
would not be possible in these cases, and I think it would be a bit confusing for learners to see ski
used in some cases but skimage
used elsewhere.
So the question perhaps becomes: do we want to switch over to importing all of skimage
instead of only specific submodules? I think @datacarpentry/image-processing-curriculum-maintainers talked about this once before, though I cannot find the notes now, and concluded that we are modeling better practice by importing specific submodules as needed.
from image-processing.
Hi @tobyhodges,
I think https://github.com/orgs/datacarpentry/teams/image-processing-curriculum-maintainers talked about this once before, though I cannot find the notes now, and concluded that we are modeling better practice by importing specific submodules as needed.
For educational materials, I'm also in favour of importing specific submodules. So let's forget about import skimage as ski
. Do we want import skimage.filters
or from skimage import filters
though? I used to use the latter in scikit-image tutorials (e.g., from skimage import color, filters
).
Currently, file episodes/06-blurring.md
contains:
import skimage
import skimage.filters
and
from skimage.filters import gaussian
elsewhere.
I'm happy to update #294 with import fixes if we agree on a convention for importing submodules. Thanks!
from image-processing.
I believe we prefer the import skimage.filters
form because it is more explicit, making it easier for learners to identify where a particular function or submodule has come from.
I should really expand our lesson's CONTRIBUTING.md
to mention some of these stylistic things. E.g. also #291 and #288
from image-processing.
Thank you, @tobyhodges! Done f477193.
from image-processing.
Related Issues (20)
- "Loading" as a separate section HOT 1
- Ep3: Image not writeable HOT 6
- Ep3: Wrong file name `data/sudoku.jpg` HOT 5
- Ep3: iio.imread is unreliable HOT 8
- Convert sudoku.png image to pure RGB (without alpha channel) HOT 9
- Release new version of image dataset on FigShare HOT 2
- Use `uint8` or `float64` for grayscale images? HOT 1
- Using image as a variable name HOT 7
- Carpentries Workbench Transition HOT 22
- Showcase image processing at AUNZ community call HOT 7
- Links need to be fixed in CONTRIBUTING.md
- latest version of lesson using "import imageio.v3 as iio" causes error HOT 4
- 'code' folder should be re-established/replaced HOT 5
- Code snippet docstring formatting HOT 4
- Contributing guide should be customised further
- Ep 5 - Using a Mask for a Histogram exercise error in solution HOT 3
- Link to image publication & analysis checklists HOT 2
- Mask in episode 4 has no shadow HOT 1
- Matplotlib is currently used in a hybrid way (explicit vs. implicit interfaces) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from image-processing.