Comments (5)
@vreuter what do you think of making AttributeDIct a separate project and putting it on pypi?
Actually, looks there someone else has already done something similar... https://pypi.org/project/attributedict/
And here's a more popular, older project that does the same thing: https://pypi.org/project/attrdict/
any chance to we can use those...?
from pypiper.
Yeah, this has been on my radar for awhile.
for now let's just leave them duplicated since it's working and I don't want to open this box quite yet.
long term I think the answer is that AttributeDict will reside in models, and both looper and pypiper will import it from models. So this will happen at the models/looper division.
from pypiper.
related to #68
from pypiper.
Definitely in favor of centralizing. I think the implementation used in this project may have slightly different default behavior regarding things like the "identity" return for missing attributes (since, e.g., requesting samtools
and returning "samtools" is more likely to make sense in the pipeline context than in the project context.) That's just something that we should be aware/careful of when this is done.
Also fine with moving to an external implementation like you suggest. There are some custom behaviors like the identity thing just mentioned, and probably some others like path expansions that are automatic for us that we'd need to make accommodating changes for, or extend the functionality offered by an external project's data types.
from pypiper.
Closed in favor of #122
from pypiper.
Related Issues (20)
- multi=False causes Errno 29 illegal seek during pytest teardown HOT 4
- unifying pipestat config with pipestat constructor HOT 2
- KeyError: 'Time' when using pipestat via pypiper HOT 6
- docs outdated? HOT 2
- Critical bugs with reporting results HOT 3
- Logs are overwritten with new pipeline run HOT 6
- `logger_kwargs` isn't used in one branch of the pipeline manager setup HOT 4
- Pipeline log file could collide with filepath given to logmuse HOT 2
- `pipestat_project_name` parameter to manager constructor is currently unused HOT 3
- Running tests locally generates (or changes?) outputs that are not `.gitignore`d HOT 1
- Replace read_yaml_data with yacman.load_yaml HOT 1
- Idea: "describe" a pipeline
- Add `nofail` to `Stage`
- Add summary of `Stage`s of `Pipeline` which failed
- Rerun of downstream `Stage`s should be configurable, probably opt-in
- Setting the pipeline folder to a path that's not absolute causes problem for checkpointing HOT 1
- Pipeline "failure reason" loses some information
- Could `-N` / `--new-start` be given an alias, like `--clobber` or `--overwrite`?
- `Pipeline` doesn't respect `-N` / `--new-start`
- how to deal with huge fastq files HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pypiper.