Code Monkey home page Code Monkey logo

Comments (5)

nsheff avatar nsheff commented on August 16, 2024 1

@vreuter what do you think of making AttributeDIct a separate project and putting it on pypi?

Actually, looks there someone else has already done something similar... https://pypi.org/project/attributedict/

And here's a more popular, older project that does the same thing: https://pypi.org/project/attrdict/

any chance to we can use those...?

from pypiper.

nsheff avatar nsheff commented on August 16, 2024

Yeah, this has been on my radar for awhile.
for now let's just leave them duplicated since it's working and I don't want to open this box quite yet.

long term I think the answer is that AttributeDict will reside in models, and both looper and pypiper will import it from models. So this will happen at the models/looper division.

from pypiper.

nsheff avatar nsheff commented on August 16, 2024

related to #68

from pypiper.

vreuter avatar vreuter commented on August 16, 2024

Definitely in favor of centralizing. I think the implementation used in this project may have slightly different default behavior regarding things like the "identity" return for missing attributes (since, e.g., requesting samtools and returning "samtools" is more likely to make sense in the pipeline context than in the project context.) That's just something that we should be aware/careful of when this is done.

Also fine with moving to an external implementation like you suggest. There are some custom behaviors like the identity thing just mentioned, and probably some others like path expansions that are automatic for us that we'd need to make accommodating changes for, or extend the functionality offered by an external project's data types.

from pypiper.

nsheff avatar nsheff commented on August 16, 2024

Closed in favor of #122

from pypiper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.