datauri 3.0 - RFC 🎉 about datauri HOT 4 CLOSED

Build and test

• Keep datauri module and datauri-cli on a single monolithic repo using lerna.js instead of current code, or split them in 2 github projects?

While Lerna is raising in popularity for larger projects, for the "lib + cli" case trend seems to go the other way these days. I think most people like having separated repos since it helps defining responsibility of each module and gives more flexibility for maintainers while reducing the overall size for people consuming only the library. With this in mind I would prefer to move forward with 2 github/npm.

• Use jest as test runner instead of mocha.

No strong feelings either way, we should consider that a change is always an extra effort that will be time consuming. I think it's safe to have this on the backlog with a lower priority.

• For code coverage, use istanbul instead of blanket.js. Should keep coveralls? Anything newer and more interesting?

Same thing as above, maybe with a higher priority though since it's probably a less effort-demanding task and Istanbul is the standard for coverage these days.

• Run node benchmark tests. For this topic, I might grab some ideas from fast-memoize, since I'm not an expert on this subject yet. I'm open for suggestions/help though.

I'll defer to whatever @caiogondim recommends for this one since I have no experience benchmarking libraries.

• Write code for node.js 6+ and support old versions with Babel transpiler, or move back to fully es5?

Is there any real reason to move back? I think ES6+ is def here to stay and Babel transpilation is popular enough.

from datauri.

@ruyadorno Thanks for the input! Very reasonable thoughts.

One more thing

• Use Typescript and expose it's .d.ts files right into the repo.

VS.

• Expose types at @types/datauri

from datauri.

@heldr I think exposing types as part of this package makes more sense. @types is actually only used if the maintainer does not like them to be in the repository but since you already proposed it i assume you are in favour of it 😊 Let me know if you need help with it or are you already working on it?

from datauri.

Closing this since for now I'll be focusing only in TS types.

from datauri.