Add API to setup RabbitMQ topology on producer connect about broadway_rabbitmq HOT 4 CLOSED

I would honestly prefer Option #1. Maybe call it after_connect to mirror DBConnection?

from broadway_rabbitmq.

If we go with #1, let's absolutely call it after_connect, awesome suggestion.

Personally I'm more inclined to go with #2 though even if I didn't express preference (not avoid pushing the needle 😄). #2 is more declarative plus you don't have to deal with failure manually since we can deal with that in the options. I'd go with :declare_exchanges and with "Option 2" in the exchange-to-exchange bindings though.

FWIW, I see the point of being generic with after_connect, but I don't think you'd do anything that is not declaring exchanges or binding exchanges together. Can you think of other use cases for after_connect that maybe I'm missing?

from broadway_rabbitmq.

I am not sure if #1 would be used for other cases but at the same time I am not sure if #2 would cover all cases. What if the exchange is coming from an environemnt variable? Now we have to make it a MFA and etc. What if there are other topologies? I think at some point we need to say "it is in your hands now" and it is an arbitrary line but it seems starting with the base case is a safer bet here. :)

from broadway_rabbitmq.

@josevalim you have a point and the thing that is bringing me over the line anyways is that we can always add support for the declarative way in the future if we wanted to. I'll make a PR for this.

from broadway_rabbitmq.