Comments (7)
Yes same thoughts as @josevalim really. If they share a lot I'd be okay to put it here, but Iām really fine with broadway_amqp1
or something like that. RabbitMQ might support AMQP 1.0 via plugins, but it's historically (and currently) still running on AMQP 0.9, so Iām ok with broadway_rabbitmq not supporting AMQP 1.0.
from broadway_rabbitmq.
I think we could ship with two different producers here... but it depends if they will actually share a reasonable amount of code. If not, then I would go with separate repos. :)
from broadway_rabbitmq.
Thoughts @whatyouhide?
from broadway_rabbitmq.
Sounds good and makes sense to me .Sounds like I should close this issue now, possibly open another on broadway repo? Not sure, let me know how you want to proceed and handle the logistics on this one.
from broadway_rabbitmq.
@starbelly yes, I'll go ahead and close this issue as there is nothing to do right now in broadway_rabbitmq itself.
Iām not sure what the issue in Broadway would be though? š In any case, if there's something to do there, yes go ahead and open.
let me know how you want to proceed and handle the logistics on this one
My take is that you can open-source the AMQP 1.0 producer and later on we can figure it out if we want to make it officially supported by the Broadway team. What do you think?
from broadway_rabbitmq.
@whatyouhide Got it, was a bit of confusion my end š
from broadway_rabbitmq.
Related Issues (20)
- Crash supervisor after killing Broadway process HOT 1
- econnrefused when deploying elixir project with broadway HOT 3
- ACK timeout kills connection without getting restarted HOT 4
- Ability to retrieve the AMQP Channel used by the Producer HOT 3
- Any plan for new version release? HOT 2
- Allow use of nimble_options 0.4.0 in broadway_rabbitmq HOT 2
- Retrieving additional information from AMQP.Queue.declare HOT 2
- Allow usage of connection/channel pool HOT 6
- Update nimble options requirement HOT 1
- publish new version
- Broadway.prepare_messages/2 callback always receives exactly one message HOT 16
- Pass in an established connection HOT 11
- Proposal: require users to specify `:on_failure` HOT 1
- Questions about supported versions of the AMQP protocol HOT 2
- AMQP 2.0 HOT 3
- Multiple producers is an anti-pattern, right? HOT 12
- Working dead letter example HOT 1
- producers keep failing with declare: [no_wait: true] HOT 5
- :message_count is not honoured as metadata option. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from broadway_rabbitmq.