`qos: [prefetch_count: 0]` doesn't work about broadway_rabbitmq HOT 5 CLOSED

Good catch. If prefetch_size is 0, we shouldn't touch buffer_size at all, which will default to 10_000, and also allow users to customize it. WDYT? PR please?

from broadway_rabbitmq.

@josevalim sounds good, I'll get to it then. 🙂

from broadway_rabbitmq.

I am now getting to this. @josevalim, would you prefer customisation limited to buffer_size or a more general approach where users can override any GenStage producer options like this:

producers: [
  default: [
    module: {
      # ...
      gen_stage: [ buffer_size: 1000, buffer_keep: :first ]
    }
  ]
]

I can see how the two in the example could be useful, but the other two options (:demand, :dispatcher) are less likely to be used as they would mess with the internals.

If we're going with the selective approach, I would put :buffer_size and :buffer_keep at the same level as :qos (so not gen_stage: [buffer_size: 1000]).

from broadway_rabbitmq.

I would keep them merged for now. Here is what I would do:

1. if prefetch_count is not 0, we keep the behaviour from today
2. if prefetch_count is 0, then we aks the user to explicitly set at leasts the buffer_size too

WDYT?

from broadway_rabbitmq.

Sounds good.

from broadway_rabbitmq.