dasaav-dsv / liber Goto Github PK

More wishlist stuff / "did you know this exists" stuff.

In SpEffectVfxParam, you can apply several fun things to your weapons:

traceSfxIdOffsetType

Lets you change the default weapon trails to Magic, Fire, Lightning etc.
How it works is as follows:

• Every weapon under EquipParamWeapon has traceSfxId entries, such as 401000. This is an FXR ID corresponding to a vfx file.
• The int under traceSfxIdOffsetType offsets this id by 10000 + ((traceSfxIdOffsetType - 1) * 1000).
• Example: You use a Fire Grease, which has a traceSfxIdOffsetType SpEffectVfx with value 2, which stands for Fire. Your weapon will now use 401000 + 10000 + ((2 - 1) * 1000) = 412000 as its swing trail.

This is cool, however traceSfxIdOffsetType is arbitrarily restricted to a fixed list of values. Other values have no effect, even if you add VFX at those IDs. This doesn't make much sense due to the otherwise very dynamic nature of the offset calculation.

Make it possible to enter an arbitrary number! That way we can create more trails whenever we want.

soulParamIdForWepEnchant

Lets you apply a PhantomParam-esque visual shader overlay to your weapon. For example, when you use Determination/Royal Knight's Resolve, your weapon glows white, like a Dark Souls cooperator.

This is, again, based on an enum which vaguely corresponds to the traceSfx ones, but only vaguely.

There does not appear to be any way to edit these phantomparam looks, nor to add additional ones. It's a hardcoded list of fixed looks. Again, this would be appreciated.

If you think it's a good idea, I might dump some feature requests in here sometimes, use cases I've seen elsewhere or have myself.

Not in a "ADD THIS NOW PLSSSSS" kinda desperate way, just to catalogue what use cases exist.

ER does not use .mtd and .ffx, but .matbin and .fxr. The internal names are a leftovers from earlier games (and are misleading)

Doxygen documentation needs examples and code snippets

Get how many runes are in the bloodstain, read/change its location, place it or remove it, etc

The current clang-format formatting options may not be ideal in terms of visibility and consistency. Rethink and apply new clang-format formatting to the entire codebase.

Somehow, run tests on ELDEN RING from GitHub actions

Rewrite comments/annotations to support doxygen, and add extra ones where needed

The way symbols are stored in the binary, loaded and downloaded should be documented

const T* str may instead be pointing to a C string?

when you press L3 in the crafting menu, you can select an alternate sort type which includes the category separator bars from the regular inventory

this is reset every time you close and reopen the menu

controlling this via libER would be cool