darthjahus / cashtip-telegram Goto Github PK

The bot originally uses getaddressesbyaccount <account_name> to know user's address, then queries getbalance <address> to know the balance.

When tested on bitcoind, getbalance <address> returned 0 while getbalance <account_name> returned correct balance.

Is there a way to learn the balance of an address or should we switch to querying balance of a specific account?

From getbalance help:

minconf (numeric, optional, default=1) Only include transactions confirmed at least this many times.

Is using minconf=0 safe for balance?
In this case, would we allow spending unconfirmed funds?
If we don't, user might be disturbed by having funds by getting an error while trying to spend them. Maybe show unconfirmed balance as well as confirmed balance?

Users have asked for a /rain command that sends the same amount to active members of the group.

The feature has been implemented in DarthJahus/PandaTip-Telegram. See from version 1.8.7 to version 1.9.4.

Unlike how it has been used in PandaTip-Telegram, we need to use addresses instead of account names while building the {"account": amount} dict for sendmany command.

sendfrom "fromaccount" "tobitcoinaddress" amount ( minconf "comment" "comment-to" )

If the balance is shown in main unit, the user will have to manually convert to whole bits (₿) in order to proceed.

Moreover, we need to show the user how much he has got and how much he can withdraw, when showing an error about insufficient amount.

'error':{'code':-3,'message':'Invalid amount'}

Amounts show <type 'list'>: [0.00023999999999999998], and results in invalid amount passed in RPC.