dart-bitcoin / bip39 Goto Github PK

View Code? Open in Web Editor NEW

44.0 44.0 72.0 52 KB

License: BSD 3-Clause "New" or "Revised" License

Dart 100.00%

bip39's People

Contributors

Stargazers

Watchers

Forkers

mctrivia jjjachyty jungsoo827 asssaf fkfk cochainio komodoplatform thomasvandendijk sfzxc jbdtky scibizinformatics invertedx mrwude lpreimesberger yauquenlay sumkey vdeurzen-bux theosirian kithau-hcb spruceid willyfromtheblock ookami-kb reddwarf03 softwareboy92 devanshigarg08 btccrdz parodybit hijayjay abbasghomi rasouliali1379 true-will 249109296 jin9393 poka-it yitokenlabs overgaardmorten tribe-health pgg-x mountaincod3r zapit-io cypherstack baby636 xavi-reloaded saentari niclas9 freshcutgg voola-dmcc thomasfercher omarhatem28 ali77gh luciensong adobreliasolutions bhattiahasn augustu1987 tigerszheng abelortiz1982 wstueve banksocial jircs1 vespr-wallet mohammadkarbalaee planq-network

bip39's Issues

about null-safety

Hi.
I am wondering when the null-safety will be updated.

plz, update

pointycastle: ^2.0.0
hex: ^0.1.2

Thanks.

Project maintenance!

Hey!

Project maintenance would be nice. People appreciate your work and are willing to spend some time with your project. But you need to update the pub.dev package as well!

Derrived address different then expected

Hey, I am using this library to derive accounts from the deprivation path of m/44'/60'/0'/0/0 which works fine, but when I derive path with m/44'/60'/0'/0/1 it is inconsistent with what we get from metamask or other applications.

I am using this mnemonic company loud estate century olive gun tribe pulse bread play addict amount

0th address if fine which is 0x2Ee331840018465bD7Fe74aA4E442b9EA407fBBE
from 1st address it gives different account then expected, it should give 0x97F5aE30eEdd5C3c531C97E41386618b1831Cb7b but its giving 0xeeed912ce027042b94ea6288001c27541d2cc59b
You can check accounts with this site https://iancoleman.io/bip39/

I am using this snippet to derive account

    final root = bip32.BIP32.fromSeed(HEX.decode(seed));
    final child1 = root.derivePath("m/44'/60'/0'/0/1");
    final privateKey = HEX.encode(child1.privateKey);
    final private = EthPrivateKey.fromHex(privateKey);
    final address = await private.extractAddress();```

how to use mnemonicToSeed() with password?

`_randomBytes` generates non-uniform random values

bip39.generateMnemonic uses the Random.secure() CSPRNG from the dart:math library to generate entropy for the mnemonic in _randomBytes.

bip39/lib/src/bip39_base.dart

Lines 40 to 47 in 3633daa

    
           Uint8List _randomBytes(int size) { 
        
             final rng = Random.secure(); 
        
             final bytes = Uint8List(size); 
        
             for (var i = 0; i < size; i++) { 
        
               bytes[i] = rng.nextInt(_SIZE_BYTE); 
        
             } 
        
             return bytes; 
        
           }

Here _SIZE_BYTE is defined as 255 (on line 10). Since the nextInt method generates integers in the half-open interval [0, max) for a given upper bound max, the value 255 will never be generated. This means that the generated entropy will not be uniformly random. This is an issue if the library is used to generate private keys (e.g. using BIP32).

Project compatible with platform web

Like BIP32 for example, could you migrate the project with the compatibility with platform web please

Is it possible to get mnemonic from seedBytes?

  var seedBytes = bip39.mnemonicToSeed(bip39.generateMnemonic()); 

  String mnemonic = bip39.seedToMnemonic(seedBytes);  // <----- is this possible at all?

Please consider updating the dependencies and releasing a new build

pointycastle: ^3.6.0
crypto: ^3.0.2

Chinese mnemonic

I am currently facing an issue converting Chinese mnemonics to hex. The returned string does not match the intended result. Everything works fine when attempting on English. Thanks in advance.

String plainText = "成山何阀臣愈梅握厂坑磷正熊紧簧";
String seedHex = bip39.mnemonicToSeedHex(plainText);
// result: f9efae87296519949ddecfb4fecf59beec3a1bb71ecfd3452aa653c5d9d9af9cfe017916a000151527b22ee79a86b0a24836b024696534fa2a8c0ca403540533

// intended result:
41656441c5621160d8d67aa48a99818e1bb0ef9668d20f22b6129662e14a7ad8b8ed2125c66516bbb3bc96ce109cd919a69c60c7263c6eafb1fb9032d6749556

ethereum

How check its unvalid for which substring?

dependency crypto ^3.0.0

bip39/pubspec.yaml

Line 13 in 78b7dee

crypto: ^2.0.3

any harm in bumping this to ^3.0.0 for compatability reasons?

	Uint8List _randomBytes(int size) {
	final rng = Random.secure();
	final bytes = Uint8List(size);
	for (var i = 0; i < size; i++) {
	bytes[i] = rng.nextInt(_SIZE_BYTE);
	}
	return bytes;
	}