Telling zoning apart from log out/in about darkstar HOT 8 CLOSED

Not sure how it's supposed to work in retail but i've got it (deleting status effects on logging out) working locally by setting a boolean to true when constructing a char entity (when logging in) and setting it to false after deleting status effects by EFFECTFLAG_ON_LOGIN.
Holding off on committing until this is confirmed to be the correct way to implement this.

from darkstar.

nah, i'm sure there's a better way. i'll look into it this weekend

from darkstar.

well at any rate, makes more sense to delete them while logging out rather than logging in (then you don't save the ones that expire anyways to the db)

from darkstar.

is this still a thing?

from darkstar.

Yes. needToZone() still has its state changed on relogging into same zone and should not. Along with my failure to work around this issue for buffs that need to be removed only on zoning, but are stripped by logout.

from darkstar.

203a303

from darkstar.

0 duration effects is another issue, which i will probably fix later (once i come up with a non-ugly way to do it)

from darkstar.

Thanks demo.

from darkstar.