The ngxs-crud-app's discuss from daptontech

daptontech / ngxs-crud-app Goto Github PK

View Code? Open in Web Editor NEW

Angular NGXS CRUD Example

JavaScript 8.89% TypeScript 75.45% HTML 15.00% CSS 0.66%

ngxs-crud-app's Issues

Potentially unsubscribed subscription

I noticed that on line:

ngxs-crud-app/src/app/form/form.component.ts

Line 54 in 1b1e979

onSubmit() {

the function:

onSubmit() {
    if (this.editTodo) {
      this.formSubscription.add(
        this.store.dispatch(new UpdateTodo(this.todoForm.value, this.todoForm.value.id)).subscribe(() => {
          this.clearForm();
        })
      );
    } else {
      this.formSubscription.add(
        this.formSubscription = this.store.dispatch(new AddTodo(this.todoForm.value)).subscribe(() => {
          this.clearForm();
        })
      );
    }
  }

might cause an unsubscribed subscription. Accidentally, you wrote

this.formSubscription.add(
        this.formSubscription = this.store.dispatch(new AddTodo(this.todoForm.value)).subscribe(() => {
          this.clearForm();
        })

while it should have been:

this.formSubscription.add(
        this.store.dispatch(new AddTodo(this.todoForm.value)).subscribe(() => {
          this.clearForm();
        })

This could lead to the subscription made on the ngOnInit:

this.formSubscription.add(
      this.selectedTodo.subscribe(todo => {
        if (todo) {
          this.todoForm.patchValue({
            id: todo.id,
            userId: todo.userId,
            title: todo.title
          });
          this.editTodo = true;
        } else {
          this.editTodo = false;
        }
      })
    );